Fix for pr2093: direct operands aren't necessarily addresses, so don't
authorEli Friedman <eli.friedman@gmail.com>
Tue, 26 Feb 2008 18:37:49 +0000 (18:37 +0000)
committerEli Friedman <eli.friedman@gmail.com>
Tue, 26 Feb 2008 18:37:49 +0000 (18:37 +0000)
try to simplify them.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47610 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/CodeGenPrepare.cpp
test/CodeGen/X86/2008-02-26-AsmDirectMemOp.ll [new file with mode: 0644]

index e6f7283ef4efbcc0284b06ae03d9b491c09168dd..15ccbbd42043da7cdd70e73a1d850c9ac4dfbfdc 100644 (file)
@@ -970,7 +970,8 @@ bool CodeGenPrepare::OptimizeInlineAsmInst(Instruction *I, CallSite CS,
     // Compute the constraint code and ConstraintType to use.
     OpInfo.ComputeConstraintToUse(*TLI);
 
-    if (OpInfo.ConstraintType == TargetLowering::C_Memory) {
+    if (OpInfo.ConstraintType == TargetLowering::C_Memory &&
+        OpInfo.isIndirect) {
       Value *OpVal = OpInfo.CallOperandVal;
       MadeChange |= OptimizeLoadStoreInst(I, OpVal, OpVal->getType(),
                                           SunkAddrs);
diff --git a/test/CodeGen/X86/2008-02-26-AsmDirectMemOp.ll b/test/CodeGen/X86/2008-02-26-AsmDirectMemOp.ll
new file mode 100644 (file)
index 0000000..3ba31f4
--- /dev/null
@@ -0,0 +1,17 @@
+; RUN: llvm-as < %s | llc -march=x86
+
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32"
+target triple = "i386-pc-linux-gnu"
+
+define void @dct_unquantize_h263_intra_mmx(i16* %block, i32 %n, i32 %qscale) nounwind  {
+entry:
+       %tmp1 = shl i32 %qscale, 1              ; <i32> [#uses=1]
+       br i1 false, label %bb46, label %bb59
+
+bb46:          ; preds = %entry
+       ret void
+
+bb59:          ; preds = %entry
+       tail call void asm sideeffect "movd $1, %mm6                 \0A\09packssdw %mm6, %mm6          \0A\09packssdw %mm6, %mm6          \0A\09movd $2, %mm5                 \0A\09pxor %mm7, %mm7              \0A\09packssdw %mm5, %mm5          \0A\09packssdw %mm5, %mm5          \0A\09psubw %mm5, %mm7             \0A\09pxor %mm4, %mm4              \0A\09.align 1<<4\0A\091:                             \0A\09movq ($0, $3), %mm0           \0A\09movq 8($0, $3), %mm1          \0A\09pmullw %mm6, %mm0            \0A\09pmullw %mm6, %mm1            \0A\09movq ($0, $3), %mm2           \0A\09movq 8($0, $3), %mm3          \0A\09pcmpgtw %mm4, %mm2           \0A\09pcmpgtw %mm4, %mm3           \0A\09pxor %mm2, %mm0              \0A\09pxor %mm3, %mm1              \0A\09paddw %mm7, %mm0             \0A\09paddw %mm7, %mm1             \0A\09pxor %mm0, %mm2              \0A\09pxor %mm1, %mm3              \0A\09pcmpeqw %mm7, %mm0           \0A\09pcmpeqw %mm7, %mm1           \0A\09pandn %mm2, %mm0             \0A\09pandn %mm3, %mm1             \0A\09movq %mm0, ($0, $3)           \0A\09movq %mm1, 8($0, $3)          \0A\09add $$16, $3                    \0A\09jng 1b                         \0A\09", "r,imr,imr,r,~{dirflag},~{fpsr},~{flags},~{memory}"( i16* null, i32 %tmp1, i32 0, i32 0 ) nounwind 
+       ret void
+}