ext4: add missing save_error_info() to ext4_error()
authorTheodore Ts'o <tytso@mit.edu>
Thu, 31 May 2012 03:03:56 +0000 (23:03 -0400)
committerKen Sumrall <ksumrall@android.com>
Fri, 8 Jun 2012 18:57:30 +0000 (11:57 -0700)
The ext4_error() function is missing a call to save_error_info().
Since this is the function which marks the file system as containing
an error, this oversight (which was introduced in 2.6.36) is quite
significant, and should be backported to older stable kernels with
high urgency.

Change-Id: Ia1eb8d91f37ceb67faf3b79d6bc79b899f1d6bfc
Reported-by: Ken Sumrall <ksumrall@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: ksumrall@google.com
Cc: stable@kernel.org
Signed-off-by: Ken Sumrall <ksumrall@android.com>
fs/ext4/super.c

index df121b20b0db5e227965305c61063a4b4204af63..63fe3ca32ebeb978e37fee0da39ec48a29d983d2 100644 (file)
@@ -433,6 +433,7 @@ void __ext4_error(struct super_block *sb, const char *function,
        printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: comm %s: %pV\n",
               sb->s_id, function, line, current->comm, &vaf);
        va_end(args);
+       save_error_info(sb, function, line);
 
        ext4_handle_error(sb);
 }