mrf24j40: Move INIT_COMPLETION() to before packet transmission
authorAlan Ott <alan@signal11.us>
Sun, 6 Oct 2013 03:52:22 +0000 (23:52 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Oct 2013 19:32:13 +0000 (15:32 -0400)
This avoids a race condition where complete(tx_complete) could be called
before tx_complete is initialized.

Signed-off-by: Alan Ott <alan@signal11.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ieee802154/mrf24j40.c

index 42e6deee6db55ed607170109438960523d6b9b8e..66bb4ceaabe853b794f5634a53e673b85c6c1e76 100644 (file)
@@ -344,6 +344,8 @@ static int mrf24j40_tx(struct ieee802154_dev *dev, struct sk_buff *skb)
        if (ret)
                goto err;
 
+       INIT_COMPLETION(devrec->tx_complete);
+
        /* Set TXNTRIG bit of TXNCON to send packet */
        ret = read_short_reg(devrec, REG_TXNCON, &val);
        if (ret)
@@ -354,8 +356,6 @@ static int mrf24j40_tx(struct ieee802154_dev *dev, struct sk_buff *skb)
                val |= 0x4;
        write_short_reg(devrec, REG_TXNCON, val);
 
-       INIT_COMPLETION(devrec->tx_complete);
-
        /* Wait for the device to send the TX complete interrupt. */
        ret = wait_for_completion_interruptible_timeout(
                                                &devrec->tx_complete,