ASoC: omap-mcbsp: fix snd_pcm_hw_rule_add arguments
authorGrazvydas Ignotas <notasas@gmail.com>
Thu, 8 Mar 2012 23:19:15 +0000 (01:19 +0200)
committerLiam Girdwood <lrg@ti.com>
Mon, 12 Mar 2012 13:34:24 +0000 (13:34 +0000)
We are setting SNDRV_PCM_HW_PARAM_BUFFER_SIZE based on
SNDRV_PCM_HW_PARAM_CHANNELS, not vice versa. This bug didn't
have much impact because the rules are evaluated multiple times
by the core, and intended value got set eventually.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@ti.com>
sound/soc/omap/omap-mcbsp.c

index 626e2d6db20ecd9f5b2797aed807f2cd2e935135..6912ac7cb6250ae8cf30b886d507e0ffdfe2df9a 100644 (file)
@@ -142,10 +142,10 @@ static int omap_mcbsp_dai_startup(struct snd_pcm_substream *substream,
                * smaller buffer than the FIFO size to avoid underruns
                */
                snd_pcm_hw_rule_add(substream->runtime, 0,
-                                   SNDRV_PCM_HW_PARAM_CHANNELS,
+                                   SNDRV_PCM_HW_PARAM_BUFFER_SIZE,
                                    omap_mcbsp_hwrule_min_buffersize,
                                    mcbsp,
-                                   SNDRV_PCM_HW_PARAM_BUFFER_SIZE, -1);
+                                   SNDRV_PCM_HW_PARAM_CHANNELS, -1);
 
                /* Make sure, that the period size is always even */
                snd_pcm_hw_constraint_step(substream->runtime, 0,