drm/tilcdc: panel: Add missing of_node_put
authorEzequiel Garcia <ezequiel@vanguardiasur.com.ar>
Tue, 2 Sep 2014 12:51:16 +0000 (09:51 -0300)
committerDave Airlie <airlied@redhat.com>
Wed, 17 Sep 2014 00:54:47 +0000 (10:54 +1000)
This commit adds the missing calls to of_node_put to release the node
that's currently held by the of_get_child_by_name() call in the panel
info parsing code.

Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Johannes Pointner <johannes.pointner@br-automation.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/tilcdc/tilcdc_panel.c

index 4c7aa1d8134fa8736c0f31ba28b0f99a9d7259ab..d581c532790a0f2c3760b36aa850423c9506708a 100644 (file)
@@ -311,6 +311,7 @@ static struct tilcdc_panel_info *of_get_panel_info(struct device_node *np)
        info = kzalloc(sizeof(*info), GFP_KERNEL);
        if (!info) {
                pr_err("%s: allocation failed\n", __func__);
+               of_node_put(info_np);
                return NULL;
        }
 
@@ -331,8 +332,10 @@ static struct tilcdc_panel_info *of_get_panel_info(struct device_node *np)
        if (ret) {
                pr_err("%s: error reading panel-info properties\n", __func__);
                kfree(info);
+               of_node_put(info_np);
                return NULL;
        }
+       of_node_put(info_np);
 
        return info;
 }