Fix bug exposed by this testcase:

declare int "call_operand"      (%rtx_def*, int)        ;; Prototype for: call_operand
declare int "restore_operand"   (%rtx_def*, int)        ;; Prototype for: restore_operand

%rtx_def = type opaque
%rtx_def = type int
implementation

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@934 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/SymbolTable.h b/include/llvm/SymbolTable.h
index c8eb8206ece365428ba5c651a5924f1950d5869c..0a958fded7828edfcba588b405064d30af68af0f 100644 (file)
--- a/include/llvm/SymbolTable.h
+++ b/include/llvm/SymbolTable.h
@@ -62,7 +62,7 @@ public:
   // insert - Add named definition to the symbol table...
   inline void insert(Value *N) {
     assert(N->hasName() && "Value must be named to go into symbol table!");
-    insertEntry(N->getName(), N);
+    insertEntry(N->getName(), N->getType(), N);
   }
 
   // insert - Insert a constant or type into the symbol table with the specified
@@ -72,7 +72,7 @@ public:
   inline void insert(const string &Name, Value *V) {
     assert((isa<Type>(V) || isa<ConstPoolVal>(V)) &&
           "Can only insert types and constants here!");
-    insertEntry(Name, V);
+    insertEntry(Name, V->getType(), V);
   }
 
   void remove(Value *N);
@@ -111,7 +111,7 @@ private:
   // insertEntry - Insert a value into the symbol table with the specified
   // name...
   //
-  void insertEntry(const string &Name, Value *V);
+  void insertEntry(const string &Name, const Type *Ty, Value *V);
 
   // This function is called when one of the types in the type plane are refined
   virtual void refineAbstractType(const DerivedType *OldTy, const Type *NewTy);

diff --git a/lib/VMCore/SymbolTable.cpp b/lib/VMCore/SymbolTable.cpp
index 4317968d4cdba654e71d4141a49ea24d9a09c9ff..86234167d19829cfaa6ca965b198656ed456c1a9 100644 (file)
--- a/lib/VMCore/SymbolTable.cpp
+++ b/lib/VMCore/SymbolTable.cpp
@@ -119,9 +119,7 @@ Value *SymbolTable::type_remove(const type_iterator &It) {
 // insertEntry - Insert a value into the symbol table with the specified
 // name...
 //
-void SymbolTable::insertEntry(const string &Name, Value *V) {
-  const Type *VTy = V->getType();
-
+void SymbolTable::insertEntry(const string &Name, const Type *VTy, Value *V) {
   // TODO: The typeverifier should catch this when its implemented
   assert(lookup(VTy, Name) == 0 && 
         "SymbolTable::insertEntry - Name already in symbol table!");
@@ -133,9 +131,16 @@ void SymbolTable::insertEntry(const string &Name, Value *V) {
 
   iterator I = find(VTy);
   if (I == end()) {      // Not in collection yet... insert dummy entry
-    (*this)[VTy] = VarMap();
-    I = find(VTy);
+    // Insert a new empty element.  I points to the new elements.
+    I = super::insert(make_pair(VTy, VarMap())).first;
     assert(I != end() && "How did insert fail?");
+
+    // Check to see if the type is abstract.  If so, it might be refined in the
+    // future, which would cause the plane of the old type to get merged into
+    // a new type plane.
+    //
+    if (VTy->isAbstract())
+      cast<DerivedType>(VTy)->addAbstractTypeUser(this);
   }
 
   I->second.insert(make_pair(Name, V));
@@ -153,7 +158,23 @@ void SymbolTable::refineAbstractType(const DerivedType *OldType,
                                     const Type *NewType) {
   if (OldType == NewType) return;  // Noop, don't waste time dinking around
 
-  iterator TPI = find(Type::TypeTy);
+  // Search to see if we have any values of the type oldtype.  If so, we need to
+  // move them into the newtype plane...
+  iterator TPI = find(OldType);
+  if (TPI != end()) {
+    VarMap &OldPlane = TPI->second;
+    while (!OldPlane.empty()) {
+      pair<const string, Value*> V = *OldPlane.begin();
+      OldPlane.erase(OldPlane.begin());
+      insertEntry(V.first, NewType, V.second);
+    }
+
+    // Ok, now we are not referencing the type anymore... take me off your user
+    // list please!
+    OldType->removeAbstractTypeUser(this);
+  }
+
+  TPI = find(Type::TypeTy);
   assert(TPI != end() &&"Type plane not in symbol table but we contain types!");
 
   // Loop over all of the types in the symbol table, replacing any references to