[NETFILTER]: ip6t_eui64: Fixes calculation of Universal/Local bit
authorYasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Fri, 11 Jan 2008 06:40:39 +0000 (22:40 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Jan 2008 06:40:39 +0000 (22:40 -0800)
RFC2464 says that the next to lowerst order bit of the first octet
of the Interface Identifier is formed by complementing
the Universal/Local bit of the EUI-64. But ip6t_eui64 uses OR not XOR.

Thanks Peter Ivancik for reporing this bug and posting a patch
for it.

Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/netfilter/ip6t_eui64.c

index 34ba150bfe5d9089e65301a47648a31747de73ba..41df9a578c7aa8f630f48a825b36d9111e90a032 100644 (file)
@@ -47,7 +47,7 @@ match(const struct sk_buff *skb,
                        memcpy(eui64 + 5, eth_hdr(skb)->h_source + 3, 3);
                        eui64[3] = 0xff;
                        eui64[4] = 0xfe;
-                       eui64[0] |= 0x02;
+                       eui64[0] ^= 0x02;
 
                        i = 0;
                        while (ipv6_hdr(skb)->saddr.s6_addr[8 + i] == eui64[i]