MemoryBuffer: don't force mmap when stat fails
authorAlp Toker <alp@nuanti.com>
Fri, 9 May 2014 08:57:32 +0000 (08:57 +0000)
committerAlp Toker <alp@nuanti.com>
Fri, 9 May 2014 08:57:32 +0000 (08:57 +0000)
Fix error handling introduced in r127426 that could result in MemoryBuffers not
having null termination.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208396 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Support/MemoryBuffer.cpp

index f95383dfb293e7219968211a499ae150f709187c..26c3a2ebd2695afcf7c0ee59db5f2c5029d0be44 100644 (file)
@@ -320,9 +320,8 @@ static bool shouldUseMmap(int FD,
   // RequiresNullTerminator = false and MapSize != -1.
   if (FileSize == size_t(-1)) {
     sys::fs::file_status Status;
-    error_code EC = sys::fs::status(FD, Status);
-    if (EC)
-      return EC;
+    if (sys::fs::status(FD, Status))
+      return false;
     FileSize = Status.getSize();
   }