ixgbe: Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
authorTony Breeds <tony@bakeyournoodle.com>
Thu, 9 Apr 2009 22:29:10 +0000 (22:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 11 Apr 2009 09:48:03 +0000 (02:48 -0700)
GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around
operand of '!' or change '&' to '&&' or '!' to '~'

Which I think is right.  Bracket to remove ambiguity.

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ixgbe/ixgbe_main.c

index 2856486e165523340fc1db668760683349730212..813c5bc1a8fa057ff4ec3c414f4c66975ce6e388 100644 (file)
@@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
        }
        hw->mac.ops.setup_sfp(hw);
 
-       if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
+       if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
                /* This will also work for DA Twinax connections */
                schedule_work(&adapter->multispeed_fiber_task);
        adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;