x86: bpf_jit_comp: add XOR instruction for BPF JIT
authorDaniel Borkmann <dxchgb@gmail.com>
Mon, 24 Sep 2012 07:34:51 +0000 (07:34 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Sep 2012 20:54:35 +0000 (16:54 -0400)
This patch is a follow-up for patch "filter: add XOR instruction for use
with X/K" that implements BPF x86 JIT parts for the BPF XOR operation.

Signed-off-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/x86/net/bpf_jit_comp.c

index 106c57829120b95c61822a51163bcc5339db96ef..520d2bd0b9c583de16ce246ffbf938c5c9f48b33 100644 (file)
@@ -335,9 +335,18 @@ void bpf_jit_compile(struct sk_filter *fp)
                                        EMIT1_off32(0x0d, K);   /* or imm32,%eax */
                                break;
                        case BPF_S_ANC_ALU_XOR_X: /* A ^= X; */
+                       case BPF_S_ALU_XOR_X:
                                seen |= SEEN_XREG;
                                EMIT2(0x31, 0xd8);              /* xor %ebx,%eax */
                                break;
+                       case BPF_S_ALU_XOR_K: /* A ^= K; */
+                               if (K == 0)
+                                       break;
+                               if (is_imm8(K))
+                                       EMIT3(0x83, 0xf0, K);   /* xor imm8,%eax */
+                               else
+                                       EMIT1_off32(0x35, K);   /* xor imm32,%eax */
+                               break;
                        case BPF_S_ALU_LSH_X: /* A <<= X; */
                                seen |= SEEN_XREG;
                                EMIT4(0x89, 0xd9, 0xd3, 0xe0);  /* mov %ebx,%ecx; shl %cl,%eax */