Compare all 4 bytes of the header.
authorRafael Espindola <rafael.espindola@gmail.com>
Tue, 5 Jul 2011 18:41:47 +0000 (18:41 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Tue, 5 Jul 2011 18:41:47 +0000 (18:41 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@134427 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Object/COFFObjectFile.cpp

index 158263e5b1082e551dbbc49ad04cdd30e14b74b1..00038071eadd0c17c3d3928612418868e6429798 100644 (file)
@@ -309,8 +309,9 @@ COFFObjectFile::COFFObjectFile(MemoryBuffer *Object, error_code &ec)
     if (!checkSize(Data, ec, 0x3c + 8)) return;
     HeaderStart += *reinterpret_cast<const ulittle32_t *>(base() + 0x3c);
     // Check the PE header. ("PE\0\0")
-    if (StringRef(reinterpret_cast<const char *>(base() + HeaderStart), 4)
-        != "PE\0\0") {
+    StringRef Actual(reinterpret_cast<const char *>(base() + HeaderStart), 4);
+    StringRef Expcted("PE\0\0", 4);
+    if (Actual != Expcted) {
       ec = object_error::parse_failed;
       return;
     }