param: fix return value handling in param_set_*
authorSatoru Moriya <satoru.moriya@hds.com>
Thu, 26 May 2011 23:38:04 +0000 (19:38 -0400)
committerRusty Russell <rusty@rustcorp.com.au>
Sun, 24 Jul 2011 12:36:03 +0000 (22:06 +0930)
In STANDARD_PARAM_DEF, param_set_* handles the case in which strtolfn
returns -EINVAL but it may return -ERANGE. If it returns -ERANGE,
param_set_* may set uninitialized value to the paramerter. We should handle
both cases.

The one of the cases in which strtolfn() returns -ERANGE is following:

 *Type of module parameter is long
 *Set the parameter more than LONG_MAX

Signed-off-by: Satoru Moriya <satoru.moriya@hds.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
kernel/params.c

index ed72e1330862d265e4276669830ec3f6b26c7d0d..2a4ba258f04fc4cd6b3d67981c3fe7982e3f8099 100644 (file)
@@ -225,8 +225,8 @@ int parse_args(const char *name,
                int ret;                                                \
                                                                        \
                ret = strtolfn(val, 0, &l);                             \
-               if (ret == -EINVAL || ((type)l != l))                   \
-                       return -EINVAL;                                 \
+               if (ret < 0 || ((type)l != l))                          \
+                       return ret < 0 ? ret : -EINVAL;                 \
                *((type *)kp->arg) = l;                                 \
                return 0;                                               \
        }                                                               \