Staging: unisys: Remove unnecessary cast on void pointer
authorShraddha Barke <shraddha.6596@gmail.com>
Wed, 14 Oct 2015 19:28:23 +0000 (00:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Oct 2015 05:51:48 +0000 (22:51 -0700)
void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c
drivers/staging/unisys/visorhba/visorhba_main.c

index 94419c36d2affdc2e3f54775fee102d701d7fe86..07594f43853d93dac0526f87b49321a29c9bcf6e 100644 (file)
@@ -696,7 +696,7 @@ struct visor_busdev {
 static int match_visorbus_dev_by_id(struct device *dev, void *data)
 {
        struct visor_device *vdev = to_visor_device(dev);
-       struct visor_busdev *id = (struct visor_busdev *)data;
+       struct visor_busdev *id = data;
        u32 bus_no = id->bus_no;
        u32 dev_no = id->dev_no;
 
index 41a7bca97fc0be276b974225883bfb5ba1c4a5bd..c119f20dfd44b4dfc8439fb189e42d7a15316242 100644 (file)
@@ -695,20 +695,20 @@ static void visorhba_serverdown_complete(struct visorhba_devdata *devdata)
                pendingdel = &devdata->pending[i];
                switch (pendingdel->cmdtype) {
                case CMD_SCSI_TYPE:
-                       scsicmd = (struct scsi_cmnd *)pendingdel->sent;
+                       scsicmd = pendingdel->sent;
                        scsicmd->result = DID_RESET << 16;
                        if (scsicmd->scsi_done)
                                scsicmd->scsi_done(scsicmd);
                        break;
                case CMD_SCSITASKMGMT_TYPE:
-                       cmdrsp = (struct uiscmdrsp *)pendingdel->sent;
+                       cmdrsp = pendingdel->sent;
                        cmdrsp->scsitaskmgmt.notifyresult_handle
                                                        = TASK_MGMT_FAILED;
                        wake_up_all((wait_queue_head_t *)
                                    cmdrsp->scsitaskmgmt.notify_handle);
                        break;
                case CMD_VDISKMGMT_TYPE:
-                       cmdrsp = (struct uiscmdrsp *)pendingdel->sent;
+                       cmdrsp = pendingdel->sent;
                        cmdrsp->vdiskmgmt.notifyresult_handle
                                                        = VDISK_MGMT_FAILED;
                        wake_up_all((wait_queue_head_t *)