rtc: s3c: add missing clk control
authorJoonyoung Shim <jy0922.shim@samsung.com>
Tue, 11 Aug 2015 11:28:19 +0000 (20:28 +0900)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sat, 5 Sep 2015 11:19:13 +0000 (13:19 +0200)
It's missed to call clk_unprepare() about info->rtc_src_clk in
s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in
error routine of s3c_rtc_probe.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-s3c.c

index 2e709e239dbcc0869258eab4e02d36e1dacdc4c2..3ee961529b5b4461124661da23c887ef7da3d811 100644 (file)
@@ -422,6 +422,8 @@ static int s3c_rtc_remove(struct platform_device *pdev)
 
        s3c_rtc_setaie(info->dev, 0);
 
+       if (info->data->needs_src_clk)
+               clk_unprepare(info->rtc_src_clk);
        clk_unprepare(info->rtc_clk);
        info->rtc_clk = NULL;
 
@@ -494,6 +496,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
                if (IS_ERR(info->rtc_src_clk)) {
                        dev_err(&pdev->dev,
                                "failed to find rtc source clock\n");
+                       clk_disable_unprepare(info->rtc_clk);
                        return PTR_ERR(info->rtc_src_clk);
                }
                clk_prepare_enable(info->rtc_src_clk);