rbd: drop "object_name" from rbd_req_sync_notify_ack()
authorAlex Elder <elder@inktank.com>
Wed, 25 Jul 2012 14:32:40 +0000 (09:32 -0500)
committerSage Weil <sage@inktank.com>
Tue, 31 Jul 2012 01:15:53 +0000 (18:15 -0700)
rbd_req_sync_notify_ack() only ever uses rbd_dev->header_name as the
value of its "object_name" parameter, and that value is available
within the function already.  So get rid of the parameter.

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
drivers/block/rbd.c

index d187d087a5056acf2da975ebc573d978831d9c8a..7884cb0f7ce14c0b8c2c8954f0a5262ec2f85094 100644 (file)
@@ -1186,8 +1186,7 @@ static int rbd_req_sync_read(struct rbd_device *rbd_dev,
  */
 static int rbd_req_sync_notify_ack(struct rbd_device *rbd_dev,
                                   u64 ver,
-                                  u64 notify_id,
-                                  const char *object_name)
+                                  u64 notify_id)
 {
        struct ceph_osd_req_op *ops;
        int ret;
@@ -1201,7 +1200,7 @@ static int rbd_req_sync_notify_ack(struct rbd_device *rbd_dev,
        ops[0].watch.flag = 0;
 
        ret = rbd_do_request(NULL, rbd_dev, NULL, CEPH_NOSNAP,
-                         object_name, 0, 0, NULL,
+                         rbd_dev->header_name, 0, 0, NULL,
                          NULL, 0,
                          CEPH_OSD_FLAG_READ,
                          ops,
@@ -1232,7 +1231,7 @@ static void rbd_watch_cb(u64 ver, u64 notify_id, u8 opcode, void *data)
                pr_warning(RBD_DRV_NAME "%d got notification but failed to "
                           " update snaps: %d\n", rbd_dev->major, rc);
 
-       rbd_req_sync_notify_ack(rbd_dev, hver, notify_id, rbd_dev->header_name);
+       rbd_req_sync_notify_ack(rbd_dev, hver, notify_id);
 }
 
 /*