drm/tegra: hdmi - Fix disable sequence
authorThierry Reding <treding@nvidia.com>
Wed, 16 Apr 2014 08:55:25 +0000 (10:55 +0200)
committerThierry Reding <treding@nvidia.com>
Thu, 5 Jun 2014 21:09:26 +0000 (23:09 +0200)
For some reason when the PW*_ENABLE and PM*_ENABLE fields are cleared
during disable, the HDMI output stops working properly. Resetting and
initializing doesn't help.

Comment out those accesses for now until it has been determined what to
do about them.

Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/hdmi.c

index 9cba9bf1407907334d4a42cbcade2136bbbe9a54..ab64ad1e0373b0d34e67a490dd6ee4c3aed3b162 100644 (file)
@@ -942,10 +942,18 @@ static int tegra_output_hdmi_disable(struct tegra_output *output)
         * sure it's only executed when the output is attached to one.
         */
        if (dc) {
+               /*
+                * XXX: We can't do this here because it causes HDMI to go
+                * into an erroneous state with the result that HDMI won't
+                * properly work once disabled. See also a similar symptom
+                * for the SOR output.
+                */
+               /*
                value = tegra_dc_readl(dc, DC_CMD_DISPLAY_POWER_CONTROL);
                value &= ~(PW0_ENABLE | PW1_ENABLE | PW2_ENABLE | PW3_ENABLE |
                           PW4_ENABLE | PM0_ENABLE | PM1_ENABLE);
                tegra_dc_writel(dc, value, DC_CMD_DISPLAY_POWER_CONTROL);
+               */
 
                value = tegra_dc_readl(dc, DC_CMD_DISPLAY_COMMAND);
                value &= ~DISP_CTRL_MODE_MASK;