mm/hwpoison: fix failure to split thp w/ refcount held
authorWanpeng Li <wanpeng.li@hotmail.com>
Tue, 8 Sep 2015 22:03:10 +0000 (15:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 8 Sep 2015 22:35:28 +0000 (15:35 -0700)
THP pages will get a refcount in madvise_hwpoison() w/
MF_COUNT_INCREASED flag, however, the refcount is still held when fail
to split THP pages.

Fix it by reducing the refcount of THP pages when fail to split THP.

Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/memory-failure.c

index 016c814101edbacd286b8c9aaa2cd8f43532f371..8ad923a93539b4ac99e65cf507cab377388b618c 100644 (file)
@@ -1725,6 +1725,8 @@ int soft_offline_page(struct page *page, int flags)
                if (PageAnon(hpage) && unlikely(split_huge_page(hpage))) {
                        pr_info("soft offline: %#lx: failed to split THP\n",
                                pfn);
+                       if (flags & MF_COUNT_INCREASED)
+                               put_page(page);
                        return -EBUSY;
                }
        }