Original message:
If a constant or a function has linkonce_odr linkage and unnamed_addr, mark
hidden. Being linkonce_odr guarantees that it is available in every dso that
needs it. Being a constant/function with unnamed_addr guarantees that the
copies don't have to be merged.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189886
91177308-0d34-0410-b5e6-
96231b3b80d8
static bool isAvailableExternallyLinkage(LinkageTypes Linkage) {
return Linkage == AvailableExternallyLinkage;
}
+ static bool isLinkOnceODRLinkage(LinkageTypes Linkage) {
+ return Linkage == LinkOnceODRLinkage;
+ }
static bool isLinkOnceLinkage(LinkageTypes Linkage) {
return Linkage == LinkOnceAnyLinkage ||
Linkage == LinkOnceODRLinkage ||
bool hasAvailableExternallyLinkage() const {
return isAvailableExternallyLinkage(Linkage);
}
+ bool hasLinkOnceODRLinkage() const {
+ return isLinkOnceODRLinkage(Linkage);
+ }
bool hasLinkOnceLinkage() const {
return isLinkOnceLinkage(Linkage);
}
return true;
}
+ if (GV->hasLinkOnceODRLinkage() && GV->hasUnnamedAddr() && GV->isConstant() &&
+ GV->getVisibility() != GlobalValue::HiddenVisibility) {
+ GV->setVisibility(GlobalValue::HiddenVisibility);
+ return true;
+ }
+
if (!GV->hasLocalLinkage())
return false;
if (!GS.isCompared && !GV->hasUnnamedAddr()) {
GV->setUnnamedAddr(true);
NumUnnamed++;
+ return true;
}
if (GV->isConstant() || !GV->hasInitializer())
F->eraseFromParent();
Changed = true;
++NumFnDeleted;
+ } else if (F->hasLinkOnceODRLinkage() && F->hasUnnamedAddr() &&
+ F->getVisibility() != GlobalValue::HiddenVisibility) {
+ F->setVisibility(GlobalValue::HiddenVisibility);
+ Changed = true;
} else if (F->hasLocalLinkage()) {
if (F->getCallingConv() == CallingConv::C && !F->isVarArg() &&
!F->hasAddressTaken()) {
--- /dev/null
+; RUN: opt %s -globalopt -S | FileCheck %s
+
+@foo = linkonce_odr unnamed_addr constant i32 42
+; CHECK: @foo = linkonce_odr hidden unnamed_addr constant i32 42
+
+define linkonce_odr void @bar() unnamed_addr {
+; CHECK: define linkonce_odr hidden void @bar() unnamed_addr {
+ ret void
+}
+
+define i32* @zed() {
+ call void @bar()
+ ret i32* @foo
+}