arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files
authorRusty Russell <rusty@rustcorp.com.au>
Thu, 7 Aug 2014 13:08:55 +0000 (22:38 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Thu, 7 Aug 2014 13:08:55 +0000 (22:38 +0930)
If you don't have a store function, you're not writable anyway!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
arch/powerpc/platforms/powernv/opal-dump.c

index 788a1977b9a5203cc9a477be6f9a2a7b71cdd754..85bb8fff7947f9d752d4f3adddbc0b99e76b78be 100644 (file)
@@ -102,9 +102,9 @@ static ssize_t dump_ack_store(struct dump_obj *dump_obj,
  * due to the dynamic size of the dump
  */
 static struct dump_attribute id_attribute =
-       __ATTR(id, 0666, dump_id_show, NULL);
+       __ATTR(id, S_IRUGO, dump_id_show, NULL);
 static struct dump_attribute type_attribute =
-       __ATTR(type, 0666, dump_type_show, NULL);
+       __ATTR(type, S_IRUGO, dump_type_show, NULL);
 static struct dump_attribute ack_attribute =
        __ATTR(acknowledge, 0660, dump_ack_show, dump_ack_store);