ftrace/x86: Fix order of warning messages when ftrace modifies code
authorPetr Mladek <pmladek@suse.cz>
Mon, 17 Feb 2014 15:22:53 +0000 (16:22 +0100)
committerSteven Rostedt <rostedt@goodmis.org>
Mon, 21 Apr 2014 18:00:35 +0000 (14:00 -0400)
The colon at the end of the printk message suggests that it should get printed
before the details printed by ftrace_bug().

When touching the line, let's use the preferred pr_warn() macro as suggested
by checkpatch.pl.

Link: http://lkml.kernel.org/r/1392650573-3390-5-git-send-email-pmladek@suse.cz
Signed-off-by: Petr Mladek <pmladek@suse.cz>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
arch/x86/kernel/ftrace.c

index 52819e816f87fe0ba144fd78b52143c140897da3..3d837b00502bcc770c20195d09681fc692ee3411 100644 (file)
@@ -621,8 +621,8 @@ void ftrace_replace_code(int enable)
        return;
 
  remove_breakpoints:
+       pr_warn("Failed on %s (%d):\n", report, count);
        ftrace_bug(ret, rec ? rec->ip : 0);
-       printk(KERN_WARNING "Failed on %s (%d):\n", report, count);
        for_ftrace_rec_iter(iter) {
                rec = ftrace_rec_iter_record(iter);
                /*