usb: dwc3: remove unnecessary OOM messages
authorJingoo Han <jg1.han@samsung.com>
Thu, 17 Jul 2014 03:45:11 +0000 (12:45 +0900)
committerFelipe Balbi <balbi@ti.com>
Wed, 20 Aug 2014 17:14:45 +0000 (12:14 -0500)
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/core.c
drivers/usb/dwc3/dwc3-exynos.c
drivers/usb/dwc3/dwc3-omap.c
drivers/usb/dwc3/dwc3-pci.c
drivers/usb/dwc3/gadget.c

index b769c1faaf0385dff2543592e2fe68745d1fc7c5..f2050e844b4bae97dec305180287672c69781a92 100644 (file)
@@ -186,10 +186,8 @@ static int dwc3_alloc_event_buffers(struct dwc3 *dwc, unsigned length)
 
        dwc->ev_buffs = devm_kzalloc(dwc->dev, sizeof(*dwc->ev_buffs) * num,
                        GFP_KERNEL);
-       if (!dwc->ev_buffs) {
-               dev_err(dwc->dev, "can't allocate event buffers array\n");
+       if (!dwc->ev_buffs)
                return -ENOMEM;
-       }
 
        for (i = 0; i < num; i++) {
                struct dwc3_event_buffer        *evt;
@@ -639,10 +637,9 @@ static int dwc3_probe(struct platform_device *pdev)
        void                    *mem;
 
        mem = devm_kzalloc(dev, sizeof(*dwc) + DWC3_ALIGN_MASK, GFP_KERNEL);
-       if (!mem) {
-               dev_err(dev, "not enough memory\n");
+       if (!mem)
                return -ENOMEM;
-       }
+
        dwc = PTR_ALIGN(mem, DWC3_ALIGN_MASK + 1);
        dwc->mem = mem;
        dwc->dev = dev;
index f9fb8adb785b7eb35c158dd2e9ad8e5f577fe6d8..3951a65fea048c51d6fec6b2eda72563fff5cd8a 100644 (file)
@@ -113,10 +113,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
        int                     ret;
 
        exynos = devm_kzalloc(dev, sizeof(*exynos), GFP_KERNEL);
-       if (!exynos) {
-               dev_err(dev, "not enough memory\n");
+       if (!exynos)
                return -ENOMEM;
-       }
 
        /*
         * Right now device-tree probed devices don't get dma_mask set.
index ef4936ff626c3cdea2bd0bc6e0a7e7328481a3a7..76345aceb4b6ae2a56832a41a18425daa15218b3 100644 (file)
@@ -481,10 +481,8 @@ static int dwc3_omap_probe(struct platform_device *pdev)
        }
 
        omap = devm_kzalloc(dev, sizeof(*omap), GFP_KERNEL);
-       if (!omap) {
-               dev_err(dev, "not enough memory\n");
+       if (!omap)
                return -ENOMEM;
-       }
 
        platform_set_drvdata(pdev, omap);
 
index a60bab7dfa0a431cce7fb79e9b33eaf9a65f14da..436fb08c40b8785f16e224241039e7c63899fde9 100644 (file)
@@ -103,10 +103,8 @@ static int dwc3_pci_probe(struct pci_dev *pci,
        struct device           *dev = &pci->dev;
 
        glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
-       if (!glue) {
-               dev_err(dev, "not enough memory\n");
+       if (!glue)
                return -ENOMEM;
-       }
 
        glue->dev = dev;
 
index 349cacc577d81a679cacd4494bb7ead82f11cfa4..307b5139faf3121bf9be7bb7db0c5532f34165cc 100644 (file)
@@ -789,13 +789,10 @@ static struct usb_request *dwc3_gadget_ep_alloc_request(struct usb_ep *ep,
 {
        struct dwc3_request             *req;
        struct dwc3_ep                  *dep = to_dwc3_ep(ep);
-       struct dwc3                     *dwc = dep->dwc;
 
        req = kzalloc(sizeof(*req), gfp_flags);
-       if (!req) {
-               dev_err(dwc->dev, "not enough memory\n");
+       if (!req)
                return NULL;
-       }
 
        req->epnum      = dep->number;
        req->dep        = dep;
@@ -1743,11 +1740,8 @@ static int dwc3_gadget_init_hw_endpoints(struct dwc3 *dwc,
                u8 epnum = (i << 1) | (!!direction);
 
                dep = kzalloc(sizeof(*dep), GFP_KERNEL);
-               if (!dep) {
-                       dev_err(dwc->dev, "can't allocate endpoint %d\n",
-                                       epnum);
+               if (!dep)
                        return -ENOMEM;
-               }
 
                dep->dwc = dwc;
                dep->number = epnum;
@@ -2759,7 +2753,6 @@ int dwc3_gadget_init(struct dwc3 *dwc)
 
        dwc->setup_buf = kzalloc(DWC3_EP0_BOUNCE_SIZE, GFP_KERNEL);
        if (!dwc->setup_buf) {
-               dev_err(dwc->dev, "failed to allocate setup buffer\n");
                ret = -ENOMEM;
                goto err2;
        }