Make sure a global matching asm 'i' constraint gets its
authorDale Johannesen <dalej@apple.com>
Mon, 20 Jul 2009 23:39:13 +0000 (23:39 +0000)
committerDale Johannesen <dalej@apple.com>
Mon, 20 Jul 2009 23:39:13 +0000 (23:39 +0000)
flags set properly.  (hasMemory is clearly irrelevant
when matching 'i', I don't understand what this was
supposed to be doing.)
gcc.apple/asm-block-25.c (test passed before by
accident, but generated code was wrong)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76503 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/X86/X86ISelLowering.cpp

index c20a62665854160bbe81b429228e8fe9a968c8c0..7ce51b323ca7191927b03f64c264af615e1a8e5e 100644 (file)
@@ -4557,7 +4557,7 @@ X86TargetLowering::LowerGlobalAddress(const GlobalValue *GV, DebugLoc dl,
   SDValue Result;
   if (OpFlags == X86II::MO_NO_FLAG && isInt32(Offset)) {
     // A direct static reference to a global.
-    Result = DAG.getTargetGlobalAddress(GV, getPointerTy(), Offset);
+    Result = DAG.getTargetGlobalAddress(GV, getPointerTy(), Offset, OpFlags);
     Offset = 0;
   } else {
     Result = DAG.getTargetGlobalAddress(GV, getPointerTy(), 0, OpFlags);
@@ -8911,10 +8911,7 @@ void X86TargetLowering::LowerAsmOperandForConstraint(SDValue Op,
                                                         getTargetMachine())))
       return;
 
-    if (hasMemory)
-      Op = LowerGlobalAddress(GV, Op.getDebugLoc(), Offset, DAG);
-    else
-      Op = DAG.getTargetGlobalAddress(GV, GA->getValueType(0), Offset);
+    Op = LowerGlobalAddress(GV, Op.getDebugLoc(), Offset, DAG);
     Result = Op;
     break;
   }