[media] uvcvideo: Document the struct uvc_xu_control_query query field
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 14 May 2012 07:34:34 +0000 (04:34 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 6 Jul 2012 18:26:45 +0000 (15:26 -0300)
Several developers have reported that the lack of macros for the struct
uvc_xu_control_query query field in uvcvideo.h was confusing and forced
them to look at the driver source code to find out what applications
were supposed to pass in that field.

Add a comment to the header to clarify the expected usage of the query
field.

Reported-by: Paulo Assis <pj.assis@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
include/linux/uvcvideo.h

index f46a53f060d7dd976b6767123d92a6f039a5ce0d..3b081862b9e89dcf50ab324fc77dd71ab2dfcdf6 100644 (file)
@@ -58,7 +58,8 @@ struct uvc_xu_control_mapping {
 struct uvc_xu_control_query {
        __u8 unit;
        __u8 selector;
-       __u8 query;
+       __u8 query;             /* Video Class-Specific Request Code, */
+                               /* defined in linux/usb/video.h A.8.  */
        __u16 size;
        __u8 __user *data;
 };