add fixme for dubious code. Duncan, what do you think?
authorChris Lattner <sabre@nondot.org>
Sun, 22 Nov 2009 16:16:48 +0000 (16:16 +0000)
committerChris Lattner <sabre@nondot.org>
Sun, 22 Nov 2009 16:16:48 +0000 (16:16 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@89602 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Analysis/BasicAliasAnalysis.cpp

index 45f5d40bd70862d86b830ae3d38bcd423720a672..d366a50274a2756e9d01bbe53da4221b59556736 100644 (file)
@@ -263,6 +263,7 @@ ImmutablePass *llvm::createBasicAliasAnalysisPass() {
 bool BasicAliasAnalysis::pointsToConstantMemory(const Value *P) {
   if (const GlobalVariable *GV = 
         dyn_cast<GlobalVariable>(P->getUnderlyingObject()))
+    // FIXME: shouldn't this require GV to be "ODR"?
     return GV->isConstant();
   return false;
 }