sched: Pass 'struct rq' to on_null_domain()
authorDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 6 Jan 2014 11:34:40 +0000 (12:34 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 13 Jan 2014 12:47:28 +0000 (13:47 +0100)
The on_null_domain() function is getting the cpu to retrieve the struct rq
associated with it.

Pass 'struct rq' directly to the function as the caller already has the info.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1389008085-9069-4-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c

index c47b1ceeaae900318e288e0bbe3812b48d49dc6f..fc0afc55b4a610e8e30a67830c7dc929990b60f5 100644 (file)
@@ -6868,9 +6868,9 @@ static void run_rebalance_domains(struct softirq_action *h)
        nohz_idle_balance(this_cpu, idle);
 }
 
-static inline int on_null_domain(int cpu)
+static inline int on_null_domain(struct rq *rq)
 {
-       return !rcu_dereference_sched(cpu_rq(cpu)->sd);
+       return !rcu_dereference_sched(rq->sd);
 }
 
 /*
@@ -6882,10 +6882,10 @@ void trigger_load_balance(struct rq *rq)
 
        /* Don't need to rebalance while attached to NULL domain */
        if (time_after_eq(jiffies, rq->next_balance) &&
-           likely(!on_null_domain(cpu)))
+           likely(!on_null_domain(rq)))
                raise_softirq(SCHED_SOFTIRQ);
 #ifdef CONFIG_NO_HZ_COMMON
-       if (nohz_kick_needed(rq) && likely(!on_null_domain(cpu)))
+       if (nohz_kick_needed(rq) && likely(!on_null_domain(rq)))
                nohz_balancer_kick(cpu);
 #endif
 }