drivers/rtc/rtc-ds1307.c: fix sysfs wakealarm attribute creation
authorSimon Guinot <simon.guinot@sequanux.org>
Thu, 3 Apr 2014 21:49:54 +0000 (14:49 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 3 Apr 2014 23:21:20 +0000 (16:21 -0700)
In order to allow the creation of the sysfs attribute wakealarm, this
patch moves the device_set_wakeup_capable() call above the RTC device
registration.

Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-ds1307.c

index 9e2aad68f96da5f0b560d979f021dac9007b04d3..f739be96cbc090a292c1cee095702978cf9d3a77 100644 (file)
@@ -927,6 +927,7 @@ read_rtc:
                                bin2bcd(tmp));
        }
 
+       device_set_wakeup_capable(&client->dev, want_irq);
        ds1307->rtc = devm_rtc_device_register(&client->dev, client->name,
                                &ds13xx_rtc_ops, THIS_MODULE);
        if (IS_ERR(ds1307->rtc)) {
@@ -941,7 +942,6 @@ read_rtc:
                        dev_err(&client->dev, "unable to request IRQ!\n");
                } else {
 
-                       device_set_wakeup_capable(&client->dev, 1);
                        set_bit(HAS_ALARM, &ds1307->flags);
                        dev_dbg(&client->dev, "got IRQ %d\n", client->irq);
                }