folly::dynamic: comment about std::vector const-iter erase issue

Test Plan: none

Reviewed By: delong.j@fb.com

FB internal diff: D543196

diff --git a/folly/dynamic-inl.h b/folly/dynamic-inl.h
index 94ddea4c36cdea72b2c56125bbd7ebc64e7b2584..58f89710d956fc8200eaa1c9174216ffa5cdf9cd 100644 (file)
--- a/folly/dynamic-inl.h
+++ b/folly/dynamic-inl.h
@@ -587,6 +587,9 @@ inline std::size_t dynamic::erase(dynamic const& key) {
 
 inline dynamic::const_iterator dynamic::erase(const_iterator it) {
   auto& arr = get<Array>();
+  // std::vector doesn't have an erase method that works on const iterators,
+  // even though the standard says it should, so this hack converts to a
+  // non-const iterator before calling erase.
   return get<Array>().erase(arr.begin() + (it - arr.begin()));
 }