Remove byLine(const char*) method

Summary:
Many callers of byLine method use it by providing arguments for File
explicit constructors. Added function breaks byLine(file desciptor)
use case. Commenting it out until File constructors are made exlicit to
fix failing tests.

Test Plan: unittest

Reviewed By: lucian@fb.com

FB internal diff: D1133938

Blame Revision: D1129497

diff --git a/folly/experimental/FileGen-inl.h b/folly/experimental/FileGen-inl.h
index 2825d68eaff5cf7f80610e48627587a84481007b..79f8a1dde4e4b9ca67146cd8d68415f5bf1ce492 100644 (file)
--- a/folly/experimental/FileGen-inl.h
+++ b/folly/experimental/FileGen-inl.h
@@ -135,12 +135,4 @@ inline auto byLine(File file, char delim = '\n')
        | resplit(delim);
 }
 
-/**
- * Ditto, take the filename and opens it
- */
-inline auto byLine(const char* fileName, char delim = '\n')
-  -> decltype(byLine(File(fileName))) {
-  return byLine(File(fileName), delim);
-}
-
 }}  // !folly::gen