iwlwifi: mvm: ignore temperature updates in the RX statistics notification
authorLuciano Coelho <luciano.coelho@intel.com>
Wed, 14 Jan 2015 19:39:34 +0000 (21:39 +0200)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 22 Jan 2015 15:54:09 +0000 (17:54 +0200)
If the firmware sends spontaneous DTS notfications with the
temperature (indicated in a TLV), we can ignore the temperature we get
in the RX statistics notifications.  This prevents potentially
handling the same temperature change twice.  It also ignores
notifications with temperature equal to 0 that happens from time to
time.

Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/iwl-fw-file.h
drivers/net/wireless/iwlwifi/mvm/rx.c

index 32e8b5bf2b3d1e06d3be1b65a2cc4f3e400ca1b7..115e604e1ac9411ad036bf63e8f70f0d98ee1043 100644 (file)
@@ -246,6 +246,7 @@ enum iwl_ucode_tlv_flag {
  *     the actual dwell time.
  * @IWL_UCODE_TLV_API_SCD_CFG: This firmware can configure the scheduler
  *     through the dedicated host command.
+ * @IWL_UCODE_TLV_API_ASYNC_DTM: Async temperature notifications are supported.
  */
 enum iwl_ucode_tlv_api {
        IWL_UCODE_TLV_API_BT_COEX_SPLIT         = BIT(3),
@@ -255,6 +256,7 @@ enum iwl_ucode_tlv_api {
        IWL_UCODE_TLV_API_FRAGMENTED_SCAN       = BIT(8),
        IWL_UCODE_TLV_API_BASIC_DWELL           = BIT(13),
        IWL_UCODE_TLV_API_SCD_CFG               = BIT(15),
+       IWL_UCODE_TLV_API_ASYNC_DTM             = BIT(17),
 };
 
 /**
index 02e0f37036320a586bf7049e35fb55e14481b153..7919a7b00c7a65ace1910a273b6d13457742e139 100644 (file)
@@ -516,7 +516,11 @@ int iwl_mvm_rx_statistics(struct iwl_mvm *mvm,
                .mvm = mvm,
        };
 
-       iwl_mvm_tt_temp_changed(mvm,
+       /* Only handle rx statistics temperature changes if async temp
+        * notifications are not supported
+        */
+       if (!(mvm->fw->ucode_capa.api[0] & IWL_UCODE_TLV_API_ASYNC_DTM))
+               iwl_mvm_tt_temp_changed(mvm,
                                le32_to_cpu(stats->general.radio_temperature));
 
        iwl_mvm_update_rx_statistics(mvm, stats);