[media] rc-core: use USB API functions rather than constants
authorHimangi Saraogi <himangi774@gmail.com>
Fri, 15 Aug 2014 16:22:35 +0000 (13:22 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 22 Sep 2014 20:27:01 +0000 (17:27 -0300)
This patch introduces the use of !usb_endpoint_dir_in(epd) and
!usb_endpoint_xfer_int(epd).

The Coccinelle semantic patch that makes these changes is as follows:

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) !=
-  \(USB_DIR_IN\|0x80\))
+ !usb_endpoint_dir_in(epd)

@@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) !=
- \(USB_ENDPOINT_XFER_INT\|3\))
+ !usb_endpoint_xfer_int(epd)

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/rc/streamzap.c

index 80c4feeb01ea7a47ea52e5b6ccc106b878d045d5..bf4a44272f0e3e00a01c0bc3fb44720e1732ec27 100644 (file)
@@ -362,16 +362,14 @@ static int streamzap_probe(struct usb_interface *intf,
        }
 
        sz->endpoint = &(iface_host->endpoint[0].desc);
-       if ((sz->endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK)
-           != USB_DIR_IN) {
+       if (!usb_endpoint_dir_in(sz->endpoint)) {
                dev_err(&intf->dev, "%s: endpoint doesn't match input device "
                        "02%02x\n", __func__, sz->endpoint->bEndpointAddress);
                retval = -ENODEV;
                goto free_sz;
        }
 
-       if ((sz->endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
-           != USB_ENDPOINT_XFER_INT) {
+       if (!usb_endpoint_xfer_int(sz->endpoint)) {
                dev_err(&intf->dev, "%s: endpoint attributes don't match xfer "
                        "02%02x\n", __func__, sz->endpoint->bmAttributes);
                retval = -ENODEV;