Delete Path::appendSuffix's return value; it wasn't used anywhere, which

is fine since isn't really necessary to check isValid there anyway.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@120538 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/Support/Path.h b/include/llvm/Support/Path.h
index 93a116f45c9b9d398adb768296f0278e3a70d63c..879f01373616234f14feb2bf79b337ba23dbca1f 100644 (file)
--- a/include/llvm/Support/Path.h
+++ b/include/llvm/Support/Path.h
@@ -455,14 +455,9 @@ namespace sys {
       bool appendComponent(StringRef component);
 
       /// A period and the \p suffix are appended to the end of the pathname.
-      /// The precondition for this function is that the Path reference a file
-      /// name (i.e. isFile() returns true). If the Path is not a file, no
-      /// action is taken and the function returns false. If the path would
-      /// become invalid for the host operating system, false is returned. When
-      /// the \p suffix is empty, no action is performed.
-      /// @returns false if the suffix could not be added, true if it was.
+      /// When the \p suffix is empty, no action is performed.
       /// @brief Adds a period and the \p suffix to the end of the pathname.
-      bool appendSuffix(StringRef suffix);
+      void appendSuffix(StringRef suffix);
 
       /// The suffix of the filename is erased. The suffix begins with and
       /// includes the last . character in the filename after the last directory

diff --git a/lib/Support/Path.cpp b/lib/Support/Path.cpp
index 394e013b8b2525451e7efdeb73bf6b51a9d82b2e..c3353fd0e2b212fd0825758a9b41b0bebcb7db08 100644 (file)
--- a/lib/Support/Path.cpp
+++ b/lib/Support/Path.cpp
@@ -195,19 +195,12 @@ StringRef Path::GetDLLSuffix() {
   return &(LTDL_SHLIB_EXT[1]);
 }
 
-bool
+void
 Path::appendSuffix(StringRef suffix) {
   if (!suffix.empty()) {
-    std::string save(path);
     path.append(".");
     path.append(suffix);
-    if (!isValid()) {
-      path = save;
-      return false;
-    }
   }
-
-  return true;
 }
 
 bool