ath9k: Remove incorrect diversity initialization
authorSujith Manoharan <c_manoha@qca.qualcomm.com>
Mon, 16 Sep 2013 05:07:01 +0000 (10:37 +0530)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 26 Sep 2013 19:13:50 +0000 (15:13 -0400)
Fast antenna diversity is required only for single chain
chips and the diversity initialization is done in the
per-family board setup routines. Enabling of diversity
should be done based on the calibrated EEPROM/OTP data,
doing it for all chips is incorrect.

Remove the code that sets the fast_div bit for all cards, since
the documentation for the AR_PHY_CCK_DETECT register says:

reg 642: sig_detect_cck
enable_ant_fast_div : Only used for single chain chips.

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/ar5008_phy.c
drivers/net/wireless/ath/ath9k/ar9003_phy.c

index 9e4e2a693774b866c3802822e8a2aa3dbbb5d785..cb6435e7c6f52afb44b74ebebccbcba5ddb2f673 100644 (file)
@@ -631,9 +631,6 @@ static void ar5008_hw_override_ini(struct ath_hw *ah,
                REG_WRITE(ah, AR_PCU_MISC_MODE2, val);
        }
 
-       REG_SET_BIT(ah, AR_PHY_CCK_DETECT,
-                   AR_PHY_CCK_DETECT_BB_ENABLE_ANT_FAST_DIV);
-
        if (AR_SREV_9280_20_OR_LATER(ah))
                return;
        /*
index ec37213fb7655e53afaee9c1f36a6d6dbd66c0c5..0131ba2f5d51ebf572fe93a1f3aa59547036dd93 100644 (file)
@@ -632,9 +632,6 @@ static void ar9003_hw_override_ini(struct ath_hw *ah)
               AR_PCU_MISC_MODE2_CFP_IGNORE;
        REG_WRITE(ah, AR_PCU_MISC_MODE2, val);
 
-       REG_SET_BIT(ah, AR_PHY_CCK_DETECT,
-                   AR_PHY_CCK_DETECT_BB_ENABLE_ANT_FAST_DIV);
-
        if (AR_SREV_9462(ah) || AR_SREV_9565(ah)) {
                REG_WRITE(ah, AR_GLB_SWREG_DISCONT_MODE,
                          AR_GLB_SWREG_DISCONT_EN_BT_WLAN);