pwm: lpc32xx: Properly disable the clock on device removal
authorAlban Bedel <alban.bedel@avionic-design.de>
Wed, 14 Nov 2012 11:58:14 +0000 (12:58 +0100)
committerThierry Reding <thierry.reding@avionic-design.de>
Thu, 6 Dec 2012 07:52:11 +0000 (08:52 +0100)
A single clock is used for all PWMs meaning the clock's reference count
might be between 0 and N when .remove() is called. Instead of a single
clk_disable() call pwm_disable() on each PWM, to ensure that
clk_disable() is called for each PWM that is still enabled.

Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
Acked-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
drivers/pwm/pwm-lpc32xx.c

index c9b2eb5932b121cb9afeee11181001012ceef991..971874b0707a791d4c88e27af8b8a827062a86c5 100644 (file)
@@ -136,8 +136,11 @@ static int lpc32xx_pwm_probe(struct platform_device *pdev)
 static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev)
 {
        struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
+       unsigned int i;
+
+       for (i = 0; i < lpc32xx->chip.npwm; i++)
+               pwm_disable(&lpc32xx->chip.pwms[i]);
 
-       clk_disable(lpc32xx->clk);
        return pwmchip_remove(&lpc32xx->chip);
 }