ACPI: get_throttling_state() cannot be larger than state_count
authorLen Brown <lenb@kernel.org>
Mon, 16 Mar 2009 03:36:38 +0000 (23:36 -0400)
committerLen Brown <len.brown@intel.com>
Fri, 3 Apr 2009 16:05:14 +0000 (12:05 -0400)
Reported-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/processor_throttling.c

index d27838171f4ad2b48dcfc916a1c2cc31e92b721f..5f099012f47152ef21cb1d786598841f0b1ce56d 100644 (file)
@@ -783,11 +783,9 @@ static int acpi_get_throttling_state(struct acpi_processor *pr,
                    (struct acpi_processor_tx_tss *)&(pr->throttling.
                                                      states_tss[i]);
                if (tx->control == value)
-                       break;
+                       return i;
        }
-       if (i > pr->throttling.state_count)
-               i = -1;
-       return i;
+       return -1;
 }
 
 static int acpi_get_throttling_value(struct acpi_processor *pr,