e1000e: fix pci-device enable-counter balance
authorKonstantin Khlebnikov <khlebnikov@openvz.org>
Tue, 5 Mar 2013 09:42:59 +0000 (09:42 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 7 Mar 2013 10:27:25 +0000 (02:27 -0800)
This patch removes redundant and unbalanced pci_disable_device() from
__e1000_shutdown(). pci_clear_master() is enough, device can go into
suspended state with elevated enable_cnt.

Bug was introduced in commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in v2.6.35

Cc: Bruce Allan <bruce.w.allan@intel.com>
CC: Stable <stable@kernel.org>
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Borislav Petkov <bp@suse.de>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/netdev.c

index a177b8b65c44c615271b85840c18bd217f959212..1799021944eb5bed0a14a7fd8f7d4ba8c63f9254 100644 (file)
@@ -5986,7 +5986,7 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake,
         */
        e1000e_release_hw_control(adapter);
 
-       pci_disable_device(pdev);
+       pci_clear_master(pdev);
 
        return 0;
 }