CommuteChangesDestination() should check if to-be-commuted instruction defines any...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@74602 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/CodeGen/TargetInstrInfoImpl.cpp b/lib/CodeGen/TargetInstrInfoImpl.cpp
index a5e1ee43552941887b48cd4699dfc199d8c7e569..b7595990de74c7229b9b37707571c8215f9ff904 100644 (file)
--- a/lib/CodeGen/TargetInstrInfoImpl.cpp
+++ b/lib/CodeGen/TargetInstrInfoImpl.cpp
@@ -24,14 +24,19 @@ using namespace llvm;
 // operand 1 and 2.
 MachineInstr *TargetInstrInfoImpl::commuteInstruction(MachineInstr *MI,
                                                       bool NewMI) const {
-  assert(MI->getOperand(1).isReg() && MI->getOperand(2).isReg() &&
+  const TargetInstrDesc &TID = MI->getDesc();
+  bool HasDef = TID.getNumDefs();
+  unsigned Idx1 = HasDef ? 1 : 0;
+  unsigned Idx2 = HasDef ? 2 : 1;
+
+  assert(MI->getOperand(Idx1).isReg() && MI->getOperand(Idx2).isReg() &&
          "This only knows how to commute register operands so far");
-  unsigned Reg1 = MI->getOperand(1).getReg();
-  unsigned Reg2 = MI->getOperand(2).getReg();
-  bool Reg1IsKill = MI->getOperand(1).isKill();
-  bool Reg2IsKill = MI->getOperand(2).isKill();
+  unsigned Reg1 = MI->getOperand(Idx1).getReg();
+  unsigned Reg2 = MI->getOperand(Idx2).getReg();
+  bool Reg1IsKill = MI->getOperand(Idx1).isKill();
+  bool Reg2IsKill = MI->getOperand(Idx2).isKill();
   bool ChangeReg0 = false;
-  if (MI->getOperand(0).getReg() == Reg1) {
+  if (HasDef && MI->getOperand(0).getReg() == Reg1) {
     // Must be two address instruction!
     assert(MI->getDesc().getOperandConstraint(0, TOI::TIED_TO) &&
            "Expecting a two-address instruction!");
@@ -41,21 +46,27 @@ MachineInstr *TargetInstrInfoImpl::commuteInstruction(MachineInstr *MI,
 
   if (NewMI) {
     // Create a new instruction.
-    unsigned Reg0 = ChangeReg0 ? Reg2 : MI->getOperand(0).getReg();
-    bool Reg0IsDead = MI->getOperand(0).isDead();
+    unsigned Reg0 = HasDef
+      ? (ChangeReg0 ? Reg2 : MI->getOperand(0).getReg()) : 0;
+    bool Reg0IsDead = HasDef ? MI->getOperand(0).isDead() : false;
     MachineFunction &MF = *MI->getParent()->getParent();
-    return BuildMI(MF, MI->getDebugLoc(), MI->getDesc())
-      .addReg(Reg0, RegState::Define | getDeadRegState(Reg0IsDead))
-      .addReg(Reg2, getKillRegState(Reg2IsKill))
-      .addReg(Reg1, getKillRegState(Reg2IsKill));
+    if (HasDef)
+      return BuildMI(MF, MI->getDebugLoc(), MI->getDesc())
+        .addReg(Reg0, RegState::Define | getDeadRegState(Reg0IsDead))
+        .addReg(Reg2, getKillRegState(Reg2IsKill))
+        .addReg(Reg1, getKillRegState(Reg2IsKill));
+    else
+      return BuildMI(MF, MI->getDebugLoc(), MI->getDesc())
+        .addReg(Reg2, getKillRegState(Reg2IsKill))
+        .addReg(Reg1, getKillRegState(Reg2IsKill));
   }
 
   if (ChangeReg0)
     MI->getOperand(0).setReg(Reg2);
-  MI->getOperand(2).setReg(Reg1);
-  MI->getOperand(1).setReg(Reg2);
-  MI->getOperand(2).setIsKill(Reg1IsKill);
-  MI->getOperand(1).setIsKill(Reg2IsKill);
+  MI->getOperand(Idx2).setReg(Reg1);
+  MI->getOperand(Idx1).setReg(Reg2);
+  MI->getOperand(Idx2).setIsKill(Reg1IsKill);
+  MI->getOperand(Idx1).setIsKill(Reg2IsKill);
   return MI;
 }
 
@@ -66,6 +77,9 @@ MachineInstr *TargetInstrInfoImpl::commuteInstruction(MachineInstr *MI,
 /// two-address instruction.
 bool TargetInstrInfoImpl::CommuteChangesDestination(MachineInstr *MI,
                                                     unsigned &OpIdx) const{
+  const TargetInstrDesc &TID = MI->getDesc();
+  if (!TID.getNumDefs())
+    return false;
   assert(MI->getOperand(1).isReg() && MI->getOperand(2).isReg() &&
          "This only knows how to commute register operands so far");
   if (MI->getOperand(0).getReg() == MI->getOperand(1).getReg()) {

diff --git a/test/CodeGen/ARM/2009-07-01-CommuteBug.ll b/test/CodeGen/ARM/2009-07-01-CommuteBug.ll
new file mode 100644 (file)
index 0000000..dfccefc
--- /dev/null
+++ b/test/CodeGen/ARM/2009-07-01-CommuteBug.ll
@@ -0,0 +1,130 @@
+; RUN: llvm-as < %s | llc -march=arm -mtriple=armv6-apple-darwin9
+
+@qr = external global i32              ; <i32*> [#uses=1]
+@II = external global i32*             ; <i32**> [#uses=1]
+@JJ = external global i32*             ; <i32**> [#uses=1]
+
+define arm_apcscc void @SIM(i8* %A, i8* %B, i32 %M, i32 %N, i32 %K, [256 x i32]* %V, i32 %Q, i32 %R, i32 %nseq) nounwind {
+entry:
+       br i1 undef, label %bb5, label %bb
+
+bb:            ; preds = %bb, %entry
+       br label %bb
+
+bb5:           ; preds = %entry
+       br i1 undef, label %bb6, label %bb8
+
+bb6:           ; preds = %bb6, %bb5
+       br i1 undef, label %bb8, label %bb6
+
+bb8:           ; preds = %bb6, %bb5
+       br label %bb15
+
+bb9:           ; preds = %bb15
+       br i1 undef, label %bb10, label %bb11
+
+bb10:          ; preds = %bb9
+       unreachable
+
+bb11:          ; preds = %bb9
+       br i1 undef, label %bb15, label %bb12
+
+bb12:          ; preds = %bb11
+       %0 = load i32** @II, align 4            ; <i32*> [#uses=1]
+       %1 = load i32** @JJ, align 4            ; <i32*> [#uses=1]
+       %2 = load i32* @qr, align 4             ; <i32> [#uses=1]
+       br label %bb228.i
+
+bb74.i:                ; preds = %bb228.i
+       br i1 undef, label %bb138.i, label %bb145.i
+
+bb138.i:               ; preds = %bb74.i
+       br label %bb145.i
+
+bb145.i:               ; preds = %bb228.i, %bb138.i, %bb74.i
+       %cflag.0.i = phi i16 [ %cflag.1.i, %bb228.i ], [ %cflag.1.i, %bb74.i ], [ 1, %bb138.i ]         ; <i16> [#uses=2]
+       br i1 undef, label %bb146.i, label %bb151.i
+
+bb146.i:               ; preds = %bb145.i
+       br i1 undef, label %bb228.i, label %bb151.i
+
+bb151.i:               ; preds = %bb146.i, %bb145.i
+       %.not297 = icmp ne i16 %cflag.0.i, 0            ; <i1> [#uses=1]
+       %or.cond298 = and i1 undef, %.not297            ; <i1> [#uses=1]
+       br i1 %or.cond298, label %bb153.i, label %bb228.i
+
+bb153.i:               ; preds = %bb151.i
+       br i1 undef, label %bb220.i, label %bb.nph.i98
+
+bb.nph.i98:            ; preds = %bb153.i
+       br label %bb158.i
+
+bb158.i:               ; preds = %bb218.i, %bb.nph.i98
+       %c.1020.i = phi i32 [ 0, %bb.nph.i98 ], [ %c.14.i, %bb218.i ]           ; <i32> [#uses=1]
+       %f.419.i = phi i32 [ undef, %bb.nph.i98 ], [ %f.5.i, %bb218.i ]         ; <i32> [#uses=1]
+       %cflag.418.i = phi i16 [ 0, %bb.nph.i98 ], [ %cflag.3.i, %bb218.i ]             ; <i16> [#uses=1]
+       %pj.317.i = phi i32 [ undef, %bb.nph.i98 ], [ %7, %bb218.i ]            ; <i32> [#uses=1]
+       %pi.316.i = phi i32 [ undef, %bb.nph.i98 ], [ %6, %bb218.i ]            ; <i32> [#uses=1]
+       %fj.515.i = phi i32 [ undef, %bb.nph.i98 ], [ %fj.4.i, %bb218.i ]               ; <i32> [#uses=2]
+       %fi.614.i = phi i32 [ undef, %bb.nph.i98 ], [ %fi.5.i, %bb218.i ]               ; <i32> [#uses=3]
+       %cj.811.i = phi i32 [ undef, %bb.nph.i98 ], [ %cj.11.i100, %bb218.i ]           ; <i32> [#uses=3]
+       %ci.910.i = phi i32 [ undef, %bb.nph.i98 ], [ %ci.12.i, %bb218.i ]              ; <i32> [#uses=2]
+       %3 = sub i32 %f.419.i, 0                ; <i32> [#uses=5]
+       %4 = sub i32 %c.1020.i, %2              ; <i32> [#uses=2]
+       %5 = icmp slt i32 %3, %4                ; <i1> [#uses=1]
+       br i1 %5, label %bb168.i, label %bb160.i
+
+bb160.i:               ; preds = %bb158.i
+       br i1 undef, label %bb161.i, label %bb168.i
+
+bb161.i:               ; preds = %bb160.i
+       br i1 undef, label %bb168.i, label %bb163.i
+
+bb163.i:               ; preds = %bb161.i
+       br i1 undef, label %bb167.i, label %bb168.i
+
+bb167.i:               ; preds = %bb163.i
+       br label %bb168.i
+
+bb168.i:               ; preds = %bb167.i, %bb163.i, %bb161.i, %bb160.i, %bb158.i
+       %fi.5.i = phi i32 [ %fi.614.i, %bb167.i ], [ %ci.910.i, %bb158.i ], [ %fi.614.i, %bb160.i ], [ %ci.910.i, %bb161.i ], [ %fi.614.i, %bb163.i ]           ; <i32> [#uses=2]
+       %fj.4.i = phi i32 [ %cj.811.i, %bb167.i ], [ %cj.811.i, %bb158.i ], [ %fj.515.i, %bb160.i ], [ %cj.811.i, %bb161.i ], [ %fj.515.i, %bb163.i ]           ; <i32> [#uses=2]
+       %f.5.i = phi i32 [ %3, %bb167.i ], [ %4, %bb158.i ], [ %3, %bb160.i ], [ %3, %bb161.i ], [ %3, %bb163.i ]               ; <i32> [#uses=2]
+       %scevgep88.i = getelementptr i32* %0, i32 undef         ; <i32*> [#uses=2]
+       %scevgep89.i = getelementptr i32* %1, i32 undef         ; <i32*> [#uses=2]
+       %ci.10.i = select i1 undef, i32 %pi.316.i, i32 undef            ; <i32> [#uses=0]
+       %cj.9.i = select i1 undef, i32 %pj.317.i, i32 undef             ; <i32> [#uses=0]
+       %ci.12.i = select i1 undef, i32 %fi.5.i, i32 undef              ; <i32> [#uses=2]
+       %cj.11.i100 = select i1 undef, i32 %fj.4.i, i32 undef           ; <i32> [#uses=2]
+       %c.14.i = select i1 undef, i32 %f.5.i, i32 undef                ; <i32> [#uses=1]
+       %6 = load i32* %scevgep88.i, align 4            ; <i32> [#uses=1]
+       %7 = load i32* %scevgep89.i, align 4            ; <i32> [#uses=1]
+       store i32 %ci.12.i, i32* %scevgep88.i, align 4
+       store i32 %cj.11.i100, i32* %scevgep89.i, align 4
+       br i1 undef, label %bb211.i, label %bb218.i
+
+bb211.i:               ; preds = %bb168.i
+       br label %bb218.i
+
+bb218.i:               ; preds = %bb211.i, %bb168.i
+       %cflag.3.i = phi i16 [ %cflag.418.i, %bb168.i ], [ 1, %bb211.i ]                ; <i16> [#uses=2]
+       %8 = icmp slt i32 undef, undef          ; <i1> [#uses=1]
+       br i1 %8, label %bb220.i, label %bb158.i
+
+bb220.i:               ; preds = %bb218.i, %bb153.i
+       %cflag.4.lcssa.i = phi i16 [ 0, %bb153.i ], [ %cflag.3.i, %bb218.i ]            ; <i16> [#uses=2]
+       br i1 undef, label %bb221.i, label %bb228.i
+
+bb221.i:               ; preds = %bb220.i
+       br label %bb228.i
+
+bb228.i:               ; preds = %bb221.i, %bb220.i, %bb151.i, %bb146.i, %bb12
+       %cflag.1.i = phi i16 [ 0, %bb146.i ], [ %cflag.0.i, %bb151.i ], [ %cflag.4.lcssa.i, %bb220.i ], [ 1, %bb12 ], [ %cflag.4.lcssa.i, %bb221.i ]            ; <i16> [#uses=2]
+       br i1 false, label %bb74.i, label %bb145.i
+
+bb15:          ; preds = %bb11, %bb8
+       br i1 false, label %return, label %bb9
+
+return:                ; preds = %bb15
+       ret void
+}