Use float literals when initializing float values

Summary: MSVC was correctly warning that we were initializing `float` variables with `double` literals. This just adds the explicit suffix so they are `float` literals instead.

Reviewed By: yfeldblum

Differential Revision: D3506797

fbshipit-source-id: 7eb4588958eddb984ba830e2599ac505d495783e

diff --git a/folly/test/AtomicHashMapTest.cpp b/folly/test/AtomicHashMapTest.cpp
index 9082ddd62092ea10f04719f5c9e77b5b5dbf63d1..a8c6dff220e593268e9bd9784fa11687273b7e72 100644 (file)
--- a/folly/test/AtomicHashMapTest.cpp
+++ b/folly/test/AtomicHashMapTest.cpp
@@ -181,7 +181,7 @@ TEST(Ahm, grow) {
   VLOG(1) << "Overhead: " << sizeof(AHArrayT) << " (array) " <<
     sizeof(AHMapT) + sizeof(AHArrayT) << " (map/set) Bytes.";
   uint64_t numEntries = 10000;
-  float sizeFactor = 0.46;
+  float sizeFactor = 0.46f;
 
   std::unique_ptr<AHMapT> m(new AHMapT(int(numEntries * sizeFactor), config));
 
@@ -241,7 +241,7 @@ TEST(Ahm, grow) {
 
 TEST(Ahm, iterator) {
   int numEntries = 10000;
-  float sizeFactor = .46;
+  float sizeFactor = .46f;
   std::unique_ptr<AHMapT> m(new AHMapT(int(numEntries * sizeFactor), config));
 
   // load map - make sure we succeed and the index is accurate
@@ -347,7 +347,7 @@ TEST(Ahm, map_exception_safety) {
   typedef AtomicHashMap<KeyT,Integer> MyMapT;
 
   int numEntries = 10000;
-  float sizeFactor = 0.46;
+  float sizeFactor = 0.46f;
   std::unique_ptr<MyMapT> m(new MyMapT(int(numEntries * sizeFactor)));
 
   bool success = true;
@@ -470,7 +470,7 @@ TEST(Ahm, collision_test) {
   // Doing the same number on each thread so we collide.
   numOpsPerThread = numInserts;
 
-  float sizeFactor = 0.46;
+  float sizeFactor = 0.46f;
   int entrySize = sizeof(KeyT) + sizeof(ValueT);
   VLOG(1) << "Testing " << numInserts << " unique " << entrySize <<
     " Byte entries replicated in " << FLAGS_numThreads <<

diff --git a/folly/test/ConvBenchmark.cpp b/folly/test/ConvBenchmark.cpp
index efff0bf3be39379713214738326d928d5f10d568..a6e21dd2779e65602f4281d31af3c86fec6e8eaa 100644 (file)
--- a/folly/test/ConvBenchmark.cpp
+++ b/folly/test/ConvBenchmark.cpp
@@ -509,7 +509,7 @@ char someString[] = "this is some nice string";
 char otherString[] = "this is a long string, so it's not so nice";
 char reallyShort[] = "meh";
 std::string stdString = "std::strings are very nice";
-float fValue = 1.2355;
+float fValue = 1.2355f;
 double dValue = 345345345.435;
 }
 }

diff --git a/folly/test/ConvTest.cpp b/folly/test/ConvTest.cpp
index 4bbca6dadd09e30759535c83d778a8942462a943..5512014cb2788569577019519902546d8c9ad95a 100644 (file)
--- a/folly/test/ConvTest.cpp
+++ b/folly/test/ConvTest.cpp
@@ -81,7 +81,7 @@ TEST(Conv, Type2Type) {
   int intV = 42;
   EXPECT_EQ(to<int>(intV), 42);
 
-  float floatV = 4.2;
+  float floatV = 4.2f;
   EXPECT_EQ(to<float>(floatV), 4.2f);
 
   double doubleV = 0.42;
@@ -117,7 +117,7 @@ TEST(Conv, Integral2Integral) {
 }
 
 TEST(Conv, Floating2Floating) {
-  float f1 = 1e3;
+  float f1 = 1e3f;
   double d1 = to<double>(f1);
   EXPECT_EQ(f1, d1);