incorporate review feedback

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@64158 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/Instructions.h b/include/llvm/Instructions.h
index 9503d8a543776956e8ea7b72e3edafe1c4470dfa..73e4f85b38c394e1ae1c7fc79fd1623f3d873c3d 100644 (file)
--- a/include/llvm/Instructions.h
+++ b/include/llvm/Instructions.h
@@ -2188,9 +2188,7 @@ public:
 
   BasicBlock *getSuccessor(unsigned i) const {
     assert(i < getNumSuccessors() && "Successor # out of range for Branch!");
-    if (Value *V = getOperand(i))
-      return cast<BasicBlock>(V);
-    return 0;
+    return cast_or_null<BasicBlock>(getOperand(i));
   }
 
   void setSuccessor(unsigned idx, BasicBlock *NewSucc) {