(Wangle) Remove some early returns in tests
authorHannes Roth <hannesr@fb.com>
Thu, 6 Mar 2014 01:39:47 +0000 (17:39 -0800)
committerDave Watson <davejwatson@fb.com>
Mon, 10 Mar 2014 20:50:30 +0000 (13:50 -0700)
Summary:
I guess they sneaked in when testing.

Also remove an `EXPECT_NE` that depended on `std::move` actually moving.

Test Plan: All the tests.

Reviewed By: hans@fb.com

FB internal diff: D1204971

folly/wangle/test/FutureTest.cpp

index e356d0deab2139297bd0d1426b7715cd0a797d38..e5906058f1a33e37d0ebd6cfba961b9195d06ddf 100644 (file)
@@ -171,14 +171,10 @@ TEST(Promise, setValue) {
 
   pod = Promise<Foo>();
   fpod = pod.getFuture();
-  return;
   pod.setValue(std::move(f2));
   Foo f3 = fpod.value();
   EXPECT_EQ(f.name, f3.name);
   EXPECT_EQ(f.value, f3.value);
-  EXPECT_NE(f.name, f2.name);
-
-  return;
 
   Promise<unique_ptr<int>> mov;
   auto fmov = mov.getFuture();