net: sxgbe: fix sparse warnings about static declaration
authorByungho An <bh74.an@samsung.com>
Fri, 28 Mar 2014 17:57:36 +0000 (10:57 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Mar 2014 18:42:24 +0000 (14:42 -0400)
This fixes followings:

sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:197:5:
sparse: symbol 'sxgbe_platform_freeze' was not declared. Should it be static?
>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:204:5:
sparse: symbol 'sxgbe_platform_restore' was not declared. Should it be static?
>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:228:24:
sparse: symbol 'sxgbe_platform_driver' was not declared. Should it be static?

>> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1795:6:
sparse: symbol 'sxgbe_get_ops' was not declared. Should it be static?

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Byungho An <bh74.an@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c

index 1869d4c6e454feab8b77a59e34fe05650261cc2d..ee1fd3c4568fc66fcfebbf2be744c87b2cad73ce 100644 (file)
@@ -2013,7 +2013,7 @@ static const struct net_device_ops sxgbe_netdev_ops = {
 };
 
 /* Get the hardware ops */
-void sxgbe_get_ops(struct sxgbe_ops * const ops_ptr)
+static void sxgbe_get_ops(struct sxgbe_ops * const ops_ptr)
 {
        ops_ptr->mac            = sxgbe_get_core_ops();
        ops_ptr->desc           = sxgbe_get_desc_ops();
index 94c2cd73d4a91faf607a7589cc83f8b231c10f38..b147d469a7998ee49cf7d02199d038bf58aac7c0 100644 (file)
@@ -200,14 +200,14 @@ static int sxgbe_platform_resume(struct device *dev)
        return sxgbe_resume(ndev);
 }
 
-int sxgbe_platform_freeze(struct device *dev)
+static int sxgbe_platform_freeze(struct device *dev)
 {
        struct net_device *ndev = dev_get_drvdata(dev);
 
        return sxgbe_freeze(ndev);
 }
 
-int sxgbe_platform_restore(struct device *dev)
+static int sxgbe_platform_restore(struct device *dev)
 {
        struct net_device *ndev = dev_get_drvdata(dev);
 
@@ -231,7 +231,7 @@ static const struct of_device_id sxgbe_dt_ids[] = {
 };
 MODULE_DEVICE_TABLE(of, sxgbe_dt_ids);
 
-struct platform_driver sxgbe_platform_driver = {
+static struct platform_driver sxgbe_platform_driver = {
        .probe  = sxgbe_platform_probe,
        .remove = sxgbe_platform_remove,
        .driver = {