mmc: card: fixing an false identification of SANITIZE command
authorYaniv Gardi <ygardi@codeaurora.org>
Wed, 5 Jun 2013 11:13:08 +0000 (14:13 +0300)
committerlintao <lintao@rock-chips.com>
Fri, 7 Mar 2014 11:50:37 +0000 (19:50 +0800)
Inside the routine mmc_blk_ioctl_cmd() the sanitize command is
identified according to the value of bits 16-23 of the argument.

but what happens if a different command is sent, and only by
chance, bits 16-23 contain the value of SANITIZE command ?
In that case a SANITIZE command will be falsely identified.
In order to prevent such a case, the condition is expanded and
now it also checks the opcode itself, and verifies that it is an
MMC_SWITCH opcode.

Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/card/block.c

index 4fc0e386a5e98effb94857a61f0b28080eb23a4c..5aff49a412c7f805c7c51163944d61294c7e731a 100644 (file)
@@ -539,7 +539,8 @@ static int mmc_blk_ioctl_cmd(struct block_device *bdev,
                        goto cmd_rel_host;
        }
 
-       if (MMC_EXTRACT_INDEX_FROM_ARG(cmd.arg) == EXT_CSD_SANITIZE_START) {
+       if ((MMC_EXTRACT_INDEX_FROM_ARG(cmd.arg) == EXT_CSD_SANITIZE_START) &&
+           (cmd.opcode == MMC_SWITCH)) {
                err = ioctl_do_sanitize(card);
 
                if (err)