add FIXME
authorJim Grosbach <grosbach@apple.com>
Fri, 29 Oct 2010 21:56:51 +0000 (21:56 +0000)
committerJim Grosbach <grosbach@apple.com>
Fri, 29 Oct 2010 21:56:51 +0000 (21:56 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@117718 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/ARM/AsmParser/ARMAsmParser.cpp

index 9bcced35f96bdb15e6a31a4567b28ab846d4164f..ecca95ccaddeb7d2505c04bad183eecbe46a8e4b 100644 (file)
@@ -718,6 +718,11 @@ bool ARMAsmParser::ParseInstruction(StringRef Name, SMLoc NameLoc,
   // FIXME: We need a way to check whether a prefix supports predication,
   // otherwise we will end up with an ambiguity for instructions that happen to
   // end with a predicate name.
+  // FIXME: Likewise, some arithmetic instructions have an 's' prefix which
+  // indicates to update the condition codes. Those instructions have an
+  // additional immediate operand which encodes the prefix as reg0 or CPSR.
+  // Just checking for a suffix of 's' definitely creates ambiguities; e.g,
+  // the SMMLS instruction.
   unsigned CC = StringSwitch<unsigned>(Head.substr(Head.size()-2))
     .Case("eq", ARMCC::EQ)
     .Case("ne", ARMCC::NE)