netfilter: nf_ct_helper: allocate 16 bytes for the helper and policy names
authorPablo Neira Ayuso <pablo@netfilter.org>
Sun, 15 Jan 2012 15:34:08 +0000 (16:34 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sat, 16 Jun 2012 13:08:39 +0000 (15:08 +0200)
This patch modifies the struct nf_conntrack_helper to allocate
the room for the helper name. The maximum length is 16 bytes
(this was already introduced in 2.6.24).

For the maximum length for expectation policy names, I have
also selected 16 bytes.

This patch is required by the follow-up patch to support
user-space connection tracking helpers.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/nf_conntrack_expect.h
include/net/netfilter/nf_conntrack_helper.h
net/netfilter/nf_conntrack_ftp.c
net/netfilter/nf_conntrack_irc.c
net/netfilter/nf_conntrack_sane.c
net/netfilter/nf_conntrack_sip.c
net/netfilter/nf_conntrack_tftp.c

index 4619caadd9d1055fd5caf3e7a07a10eb0e263d1b..983f00263243c66407ad4a1281167d9888378bd1 100644 (file)
@@ -59,10 +59,12 @@ static inline struct net *nf_ct_exp_net(struct nf_conntrack_expect *exp)
        return nf_ct_net(exp->master);
 }
 
+#define NF_CT_EXP_POLICY_NAME_LEN      16
+
 struct nf_conntrack_expect_policy {
        unsigned int    max_expected;
        unsigned int    timeout;
-       const char      *name;
+       char            name[NF_CT_EXP_POLICY_NAME_LEN];
 };
 
 #define NF_CT_EXPECT_CLASS_DEFAULT     0
index 1d1889409b9e92a0a7b1dca4e3fdfb3d2a34ac4b..5f5a4d9d4df51fdebfba79994e30c5307a55623a 100644 (file)
@@ -19,7 +19,7 @@ struct module;
 struct nf_conntrack_helper {
        struct hlist_node hnode;        /* Internal use. */
 
-       const char *name;               /* name of the module */
+       char name[NF_CT_HELPER_NAME_LEN]; /* name of the module */
        struct module *me;              /* pointer to self */
        const struct nf_conntrack_expect_policy *expect_policy;
 
index 8c5c95c6d34f1be6912d6ffe5ad7066b23c24f5d..44e47c9e14fb5fb0eeb96213a9f1fe903012faab 100644 (file)
@@ -512,7 +512,6 @@ out_update_nl:
 }
 
 static struct nf_conntrack_helper ftp[MAX_PORTS][2] __read_mostly;
-static char ftp_names[MAX_PORTS][2][sizeof("ftp-65535")] __read_mostly;
 
 static const struct nf_conntrack_expect_policy ftp_exp_policy = {
        .max_expected   = 1,
@@ -541,7 +540,6 @@ static void nf_conntrack_ftp_fini(void)
 static int __init nf_conntrack_ftp_init(void)
 {
        int i, j = -1, ret = 0;
-       char *tmpname;
 
        ftp_buffer = kmalloc(65536, GFP_KERNEL);
        if (!ftp_buffer)
@@ -561,12 +559,10 @@ static int __init nf_conntrack_ftp_init(void)
                        ftp[i][j].expect_policy = &ftp_exp_policy;
                        ftp[i][j].me = THIS_MODULE;
                        ftp[i][j].help = help;
-                       tmpname = &ftp_names[i][j][0];
                        if (ports[i] == FTP_PORT)
-                               sprintf(tmpname, "ftp");
+                               sprintf(ftp[i][j].name, "ftp");
                        else
-                               sprintf(tmpname, "ftp-%d", ports[i]);
-                       ftp[i][j].name = tmpname;
+                               sprintf(ftp[i][j].name, "ftp-%d", ports[i]);
 
                        pr_debug("nf_ct_ftp: registering helper for pf: %d "
                                 "port: %d\n",
index 81366c1182717fd73f7dadc643f7fc95d9f32bf0..009c52cfd1ec4b9b86a8dd7bf047f3eae249fd8a 100644 (file)
@@ -221,7 +221,6 @@ static int help(struct sk_buff *skb, unsigned int protoff,
 }
 
 static struct nf_conntrack_helper irc[MAX_PORTS] __read_mostly;
-static char irc_names[MAX_PORTS][sizeof("irc-65535")] __read_mostly;
 static struct nf_conntrack_expect_policy irc_exp_policy;
 
 static void nf_conntrack_irc_fini(void);
@@ -229,7 +228,6 @@ static void nf_conntrack_irc_fini(void);
 static int __init nf_conntrack_irc_init(void)
 {
        int i, ret;
-       char *tmpname;
 
        if (max_dcc_channels < 1) {
                printk(KERN_ERR "nf_ct_irc: max_dcc_channels must not be zero\n");
@@ -255,12 +253,10 @@ static int __init nf_conntrack_irc_init(void)
                irc[i].me = THIS_MODULE;
                irc[i].help = help;
 
-               tmpname = &irc_names[i][0];
                if (ports[i] == IRC_PORT)
-                       sprintf(tmpname, "irc");
+                       sprintf(irc[i].name, "irc");
                else
-                       sprintf(tmpname, "irc-%u", i);
-               irc[i].name = tmpname;
+                       sprintf(irc[i].name, "irc-%u", i);
 
                ret = nf_conntrack_helper_register(&irc[i]);
                if (ret) {
index 8501823b3f9b0f4af53b1392e465bb0215dee11d..ec3fc18c4ef60d07ed3d90555654ba3da6815816 100644 (file)
@@ -163,7 +163,6 @@ out:
 }
 
 static struct nf_conntrack_helper sane[MAX_PORTS][2] __read_mostly;
-static char sane_names[MAX_PORTS][2][sizeof("sane-65535")] __read_mostly;
 
 static const struct nf_conntrack_expect_policy sane_exp_policy = {
        .max_expected   = 1,
@@ -190,7 +189,6 @@ static void nf_conntrack_sane_fini(void)
 static int __init nf_conntrack_sane_init(void)
 {
        int i, j = -1, ret = 0;
-       char *tmpname;
 
        sane_buffer = kmalloc(65536, GFP_KERNEL);
        if (!sane_buffer)
@@ -210,12 +208,10 @@ static int __init nf_conntrack_sane_init(void)
                        sane[i][j].expect_policy = &sane_exp_policy;
                        sane[i][j].me = THIS_MODULE;
                        sane[i][j].help = help;
-                       tmpname = &sane_names[i][j][0];
                        if (ports[i] == SANE_PORT)
-                               sprintf(tmpname, "sane");
+                               sprintf(sane[i][j].name, "sane");
                        else
-                               sprintf(tmpname, "sane-%d", ports[i]);
-                       sane[i][j].name = tmpname;
+                               sprintf(sane[i][j].name, "sane-%d", ports[i]);
 
                        pr_debug("nf_ct_sane: registering helper for pf: %d "
                                 "port: %d\n",
index 93faf6a3a6379d5f8c4c9e52fcaf91cebdfabf66..dfd3ff382243c11f4b6c8feca6fece0c0b844a98 100644 (file)
@@ -1556,7 +1556,6 @@ static void nf_conntrack_sip_fini(void)
 static int __init nf_conntrack_sip_init(void)
 {
        int i, j, ret;
-       char *tmpname;
 
        if (ports_c == 0)
                ports[ports_c++] = SIP_PORT;
@@ -1584,12 +1583,10 @@ static int __init nf_conntrack_sip_init(void)
                        sip[i][j].expect_class_max = SIP_EXPECT_MAX;
                        sip[i][j].me = THIS_MODULE;
 
-                       tmpname = &sip_names[i][j][0];
                        if (ports[i] == SIP_PORT)
-                               sprintf(tmpname, "sip");
+                               sprintf(sip_names[i][j], "sip");
                        else
-                               sprintf(tmpname, "sip-%u", i);
-                       sip[i][j].name = tmpname;
+                               sprintf(sip_names[i][j], "sip-%u", i);
 
                        pr_debug("port #%u: %u\n", i, ports[i]);
 
index 75466fd72f4f4af4c0f948a57d06f664db503b48..81fc61c052631300290c45d9d25ef57956b4ee62 100644 (file)
@@ -92,7 +92,6 @@ static int tftp_help(struct sk_buff *skb,
 }
 
 static struct nf_conntrack_helper tftp[MAX_PORTS][2] __read_mostly;
-static char tftp_names[MAX_PORTS][2][sizeof("tftp-65535")] __read_mostly;
 
 static const struct nf_conntrack_expect_policy tftp_exp_policy = {
        .max_expected   = 1,
@@ -112,7 +111,6 @@ static void nf_conntrack_tftp_fini(void)
 static int __init nf_conntrack_tftp_init(void)
 {
        int i, j, ret;
-       char *tmpname;
 
        if (ports_c == 0)
                ports[ports_c++] = TFTP_PORT;
@@ -129,12 +127,10 @@ static int __init nf_conntrack_tftp_init(void)
                        tftp[i][j].me = THIS_MODULE;
                        tftp[i][j].help = tftp_help;
 
-                       tmpname = &tftp_names[i][j][0];
                        if (ports[i] == TFTP_PORT)
-                               sprintf(tmpname, "tftp");
+                               sprintf(tftp[i][j].name, "tftp");
                        else
-                               sprintf(tmpname, "tftp-%u", i);
-                       tftp[i][j].name = tmpname;
+                               sprintf(tftp[i][j].name, "tftp-%u", i);
 
                        ret = nf_conntrack_helper_register(&tftp[i][j]);
                        if (ret) {