memcg: optimize the "Search everything else" loop in mm_update_next_owner()
authorOleg Nesterov <oleg@redhat.com>
Wed, 4 Jun 2014 23:07:54 +0000 (16:07 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Jun 2014 23:54:03 +0000 (16:54 -0700)
for_each_process_thread() is sub-optimal. All threads share the same
->mm, we can swicth to the next process once we found a thread with
->mm != NULL and ->mm != mm.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Peter Chiang <pchiang@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/exit.c

index 5ac3c19c245c855cb195c20843c76bdef4e74014..750c2e5946170fbc07f102a18db8334f036d9f78 100644 (file)
@@ -397,9 +397,15 @@ retry:
        /*
         * Search through everything else, we should not get here often.
         */
-       for_each_process_thread(g, c) {
-               if (!(c->flags & PF_KTHREAD) && c->mm == mm)
-                       goto assign_new_owner;
+       for_each_process(g) {
+               if (g->flags & PF_KTHREAD)
+                       continue;
+               for_each_thread(g, c) {
+                       if (c->mm == mm)
+                               goto assign_new_owner;
+                       if (c->mm)
+                               break;
+               }
        }
        read_unlock(&tasklist_lock);
        /*