drm/nouveau: remove remnants of nouveau_pgraph_engine from nouveau_channel
authorBen Skeggs <bskeggs@redhat.com>
Fri, 1 Apr 2011 03:17:25 +0000 (13:17 +1000)
committerBen Skeggs <bskeggs@redhat.com>
Mon, 16 May 2011 00:48:37 +0000 (10:48 +1000)
The nouveau_wait_for_idle() call should hopefully not have been actually
necessary, we *do* wait for the channel to go idle already.  If it's
an issue somehow, the chipset-specific hooks can wait for idle themselves
before taking the lock.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_channel.c

index 8b0a6689bf27730912246ae3b5b0eee6e1fe3537..f82a276095191f9ff6a063a137cf4122784c534d 100644 (file)
@@ -268,7 +268,6 @@ nouveau_channel_put_unlocked(struct nouveau_channel **pchan)
        struct drm_device *dev = chan->dev;
        struct drm_nouveau_private *dev_priv = dev->dev_private;
        struct nouveau_fifo_engine *pfifo = &dev_priv->engine.fifo;
-       struct nouveau_pgraph_engine *pgraph = &dev_priv->engine.graph;
        unsigned long flags;
        int i;
 
@@ -294,18 +293,8 @@ nouveau_channel_put_unlocked(struct nouveau_channel **pchan)
        /* boot it off the hardware */
        pfifo->reassign(dev, false);
 
-       /* We want to give pgraph a chance to idle and get rid of all
-        * potential errors. We need to do this without the context
-        * switch lock held, otherwise the irq handler is unable to
-        * process them.
-        */
-       if (pgraph->channel(dev) == chan)
-               nouveau_wait_for_idle(dev);
-
        /* destroy the engine specific contexts */
        pfifo->destroy_context(chan);
-       if (pgraph->destroy_context)
-               pgraph->destroy_context(chan);
        for (i = 0; i < NVOBJ_ENGINE_NR; i++) {
                if (chan->engctx[i])
                        dev_priv->eng[i]->context_del(chan, i);