drivers/rtc/rtc-ds1742.c: revert "drivers/rtc/rtc-ds1742.c: remove redundant of_match...
authorAlexander Shiyan <shc_work@mail.ru>
Fri, 8 Aug 2014 21:20:07 +0000 (14:20 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 8 Aug 2014 22:57:19 +0000 (15:57 -0700)
Commit 5516f0971793 ("drivers/rtc/rtc-ds1742.c: remove redundant
of_match_ptr() helper") has description as: "'ds1742_rtc_of_match' is
always compiled in.  Hence the helper macro is not needed".

It is not true, of_match_ptr() macro makes of_device_id parameter unused
and this constant is declared with __maybe_unused attribute, so normally
this variable should be discarded by linker.  This patch revers this
commit, since there are no reason to compile of_device_id constant for
non-DT systems.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-ds1742.c

index c6b2191a4128215795e4407e6b5b35e3860cee9f..9822715db8baf32ce41e597a5ff1b710eee4bbfa 100644 (file)
@@ -231,7 +231,7 @@ static struct platform_driver ds1742_rtc_driver = {
        .driver         = {
                .name   = "rtc-ds1742",
                .owner  = THIS_MODULE,
-               .of_match_table = ds1742_rtc_of_match,
+               .of_match_table = of_match_ptr(ds1742_rtc_of_match),
        },
 };