Another minor clean-up.
authorBob Wilson <bob.wilson@apple.com>
Mon, 12 Oct 2009 20:45:53 +0000 (20:45 +0000)
committerBob Wilson <bob.wilson@apple.com>
Mon, 12 Oct 2009 20:45:53 +0000 (20:45 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@83897 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/ARM/ARMConstantIslandPass.cpp

index 33b847281a6877a6d58b55d6db3cf3d1e04b097e..e47ddd18a549f59fc0c0b94bfa8e0185f515f087 100644 (file)
@@ -952,11 +952,11 @@ MachineBasicBlock *ARMConstantIslands::AcceptWater(water_iterator IP) {
 /// group, prefer the water that's farthest away.
 bool ARMConstantIslands::LookForWater(CPUser &U, unsigned UserOffset,
                                       MachineBasicBlock *&NewMBB) {
-  water_iterator IPThatWouldPad;
-  MachineBasicBlock* WaterBBThatWouldPad = NULL;
   if (WaterList.empty())
     return false;
 
+  bool FoundWaterThatWouldPad = false;
+  water_iterator IPThatWouldPad;
   for (water_iterator IP = prior(WaterList.end()),
          B = WaterList.begin();; --IP) {
     MachineBasicBlock* WaterBB = *IP;
@@ -966,8 +966,8 @@ bool ARMConstantIslands::LookForWater(CPUser &U, unsigned UserOffset,
           (BBOffsets[WBBId] + BBSizes[WBBId])%4 != 0) {
         // This is valid Water, but would introduce padding.  Remember
         // it in case we don't find any Water that doesn't do this.
-        if (!WaterBBThatWouldPad) {
-          WaterBBThatWouldPad = WaterBB;
+        if (!FoundWaterThatWouldPad) {
+          FoundWaterThatWouldPad = true;
           IPThatWouldPad = IP;
         }
       } else {
@@ -978,7 +978,7 @@ bool ARMConstantIslands::LookForWater(CPUser &U, unsigned UserOffset,
     if (IP == B)
       break;
   }
-  if (isThumb && WaterBBThatWouldPad) {
+  if (FoundWaterThatWouldPad) {
     NewMBB = AcceptWater(IPThatWouldPad);
     return true;
   }