drm/udl: fix Bpp calculation in dumb_create()
authorDavid Herrmann <dh.herrmann@gmail.com>
Mon, 20 Jan 2014 18:54:18 +0000 (19:54 +0100)
committerDavid Herrmann <dh.herrmann@gmail.com>
Sun, 16 Mar 2014 11:11:01 +0000 (12:11 +0100)
Probably a typo.. we obviously need "(bpp + 7) / 8" instead of
"(bpp + 1) / 8". Unlikely to be hit in any sane code, but lets be safe.
Use DIV_ROUND_UP() to avoid the problem entirely and make the core more
readable.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
drivers/gpu/drm/udl/udl_gem.c

index 8d67b943ac05ce2d1dd44597d00a1e5a07fd9bdb..be4fcd0f0e0f4bfc009ccb231ecd73fcc30be0a7 100644 (file)
@@ -60,7 +60,7 @@ int udl_dumb_create(struct drm_file *file,
                    struct drm_device *dev,
                    struct drm_mode_create_dumb *args)
 {
-       args->pitch = args->width * ((args->bpp + 1) / 8);
+       args->pitch = args->width * DIV_ROUND_UP(args->bpp, 8);
        args->size = args->pitch * args->height;
        return udl_gem_create(file, dev,
                              args->size, &args->handle);