Make ivars private and use getters. Have the MachOWriter return "Mach-O

Writer" for the pass name.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@33483 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/CodeGen/MachOWriter.h b/include/llvm/CodeGen/MachOWriter.h
index dd98b950d5b359bfca2c3fe1c95aac4171e51ed8..5ec4f503318272dd034968340d1fca4a06f97014 100644 (file)
--- a/include/llvm/CodeGen/MachOWriter.h
+++ b/include/llvm/CodeGen/MachOWriter.h
@@ -85,11 +85,13 @@ namespace llvm {
     MachineCodeEmitter &getMachineCodeEmitter() const {
       return *(MachineCodeEmitter*)MCE;
     }
+    virtual ~MachOWriter();
 
-    ~MachOWriter();
+    virtual const char *getPassName() const {
+      return "Mach-O Writer";
+    }
 
     typedef std::vector<unsigned char> DataBuffer;
-
   protected:
     MachOWriter(std::ostream &O, TargetMachine &TM);
 

diff --git a/include/llvm/Target/TargetMachOWriterInfo.h b/include/llvm/Target/TargetMachOWriterInfo.h
index 6276bcfd9c31fd141e72be1804d354d709dfe26f..d85b7275f985aa4cf1dd68ecc0194b836f4532ec 100644 (file)
--- a/include/llvm/Target/TargetMachOWriterInfo.h
+++ b/include/llvm/Target/TargetMachOWriterInfo.h
@@ -24,10 +24,10 @@ namespace llvm {
   //                        TargetMachOWriterInfo
   //===--------------------------------------------------------------------===//
 
-  struct TargetMachOWriterInfo {
+  class TargetMachOWriterInfo {
     uint32_t CPUType;                 // CPU specifier
     uint32_t CPUSubType;              // Machine specifier
-
+  public:
     // The various CPU_TYPE_* constants are already defined by at least one
     // system header file and create compilation errors if not respected.
 #if !defined(CPU_TYPE_I386)
@@ -93,9 +93,8 @@ namespace llvm {
     virtual MachineRelocation GetJTRelocation(unsigned Offset,
                                               MachineBasicBlock *MBB) const;
 
-    virtual const char *getPassName() const {
-      return "Mach-O Writer";
-    }
+    uint32_t getCPUType() const { return CPUType; }
+    uint32_t getCPUSubType() const { return CPUSubType; }
   };
 
 } // end llvm namespace

diff --git a/lib/CodeGen/MachOWriter.cpp b/lib/CodeGen/MachOWriter.cpp
index 70fe79bf6870cdc09f767b4278b06773b89127fa..bc54728f58baacd8fde934c487c8ad6e3fdd3f03 100644 (file)
--- a/lib/CodeGen/MachOWriter.cpp
+++ b/lib/CodeGen/MachOWriter.cpp
@@ -461,8 +461,8 @@ void MachOWriter::EmitHeaderAndLoadCommands() {
   OutputBuffer FHOut(FH, is64Bit, isLittleEndian);
 
   FHOut.outword(Header.magic);
-  FHOut.outword(TM.getMachOWriterInfo()->CPUType);
-  FHOut.outword(TM.getMachOWriterInfo()->CPUSubType);
+  FHOut.outword(TM.getMachOWriterInfo()->getCPUType());
+  FHOut.outword(TM.getMachOWriterInfo()->getCPUSubType());
   FHOut.outword(Header.filetype);
   FHOut.outword(Header.ncmds);
   FHOut.outword(Header.sizeofcmds);

diff --git a/lib/Target/PowerPC/PPCMachOWriterInfo.h b/lib/Target/PowerPC/PPCMachOWriterInfo.h
index af47833d4cb685e81be1d0bf37afe1674bc9a9e9..153655594911e625371b7bbc38009931639e0f84 100644 (file)
--- a/lib/Target/PowerPC/PPCMachOWriterInfo.h
+++ b/lib/Target/PowerPC/PPCMachOWriterInfo.h
@@ -21,13 +21,10 @@ namespace llvm {
   // Forward declarations
   class PPCTargetMachine;
 
-  struct PPCMachOWriterInfo : public TargetMachOWriterInfo {
+  class PPCMachOWriterInfo : public TargetMachOWriterInfo {
+  public:
     PPCMachOWriterInfo(const PPCTargetMachine &TM);
     virtual ~PPCMachOWriterInfo() {}
-
-    virtual const char *getPassName() const {
-      return "PowerPC Mach-O Writer";
-    }
   };
 
 } // end llvm namespace