x86: Fix binutils-2.21 symbol related build failures
authorSedat Dilek <sedat.dilek@googlemail.com>
Tue, 8 Mar 2011 21:39:24 +0000 (22:39 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 9 Mar 2011 09:25:45 +0000 (10:25 +0100)
New binutils version 2.21.0.20110302-1 started checking that the symbol
parameter to the .size directive matches the entry name's
symbol parameter, unearthing two mismatches:

  AS      arch/x86/kernel/acpi/wakeup_rm.o
  arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
  arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with symbol `wakeup_code_start' does not evaluate to a constant

  arch/x86/kernel/entry_32.S: Assembler messages:
  arch/x86/kernel/entry_32.S:1421: Error: .size expression with
  symbol `apf_page_fault' does not evaluate to a constant

The problem was discovered while using Debian's binutils
(2.21.0.20110302-1) and experimenting with binutils from
upstream.

Thanks Alexander and H.J. for the vital help.

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: H.J. Lu <hjl.tools@gmail.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
LKML-Reference: <1299620364-21644-1-git-send-email-sedat.dilek@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/acpi/wakeup_rm.S
arch/x86/kernel/entry_32.S

index 6ce81ee9cb03077cd3a09dcd1be0d1246cfa388c..63b8ab524f2c7d553e03458a8c3468445aea003b 100644 (file)
@@ -9,4 +9,4 @@
        .globl  acpi_wakeup_code
 acpi_wakeup_code:
        .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin"
-       .size   wakeup_code_start, .-wakeup_code_start
+       .size   acpi_wakeup_code, .-acpi_wakeup_code
index c8b4efad7ebb080faeb56a9f6b539ef8cb6d7493..9ca3b0e343e5de9d56dc30d448c91615351a3870 100644 (file)
@@ -1413,7 +1413,7 @@ ENTRY(async_page_fault)
        CFI_ADJUST_CFA_OFFSET 4
        jmp error_code
        CFI_ENDPROC
-END(apf_page_fault)
+END(async_page_fault)
 #endif
 
 /*